Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(52)

Issue 2955033002: [ios clean] Moves animator and presenters under transitions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 4 days ago by sczs
Modified:
3 weeks, 4 days ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, ios-reviews+clean_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios clean] Moves animator and presenters under transitions Moves the animator and presenters directories under the transition directory. This in order to consolidate everything related to transitions under the same directory. Also, some follow up comments from: https://codereview.chromium.org/2952213003/ BUG=682880 Review-Url: https://codereview.chromium.org/2955033002 Cr-Commit-Position: refs/heads/master@{#482584} Committed: https://chromium.googlesource.com/chromium/src/+/cd56994a6694d1f3830b5ef89206446b3c600993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -570 lines) Patch
D ios/clean/chrome/browser/ui/animators/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D ios/clean/chrome/browser/ui/animators/README.md View 1 chunk +0 lines, -6 lines 0 comments Download
D ios/clean/chrome/browser/ui/animators/zoom_transition_animator.h View 1 chunk +0 lines, -44 lines 0 comments Download
D ios/clean/chrome/browser/ui/animators/zoom_transition_animator.mm View 1 chunk +0 lines, -125 lines 0 comments Download
D ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h View 1 chunk +0 lines, -22 lines 0 comments Download
D ios/clean/chrome/browser/ui/animators/zoom_transition_controller.mm View 1 chunk +0 lines, -34 lines 0 comments Download
D ios/clean/chrome/browser/ui/animators/zoom_transition_delegate.h View 1 chunk +0 lines, -16 lines 0 comments Download
M ios/clean/chrome/browser/ui/find_in_page/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D ios/clean/chrome/browser/ui/presenters/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D ios/clean/chrome/browser/ui/presenters/README.md View 1 chunk +0 lines, -6 lines 0 comments Download
D ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.h View 1 chunk +0 lines, -28 lines 0 comments Download
D ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.mm View 1 chunk +0 lines, -115 lines 0 comments Download
D ios/clean/chrome/browser/ui/presenters/menu_presentation_delegate.h View 1 chunk +0 lines, -20 lines 0 comments Download
M ios/clean/chrome/browser/ui/root/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/clean/chrome/browser/ui/root/root_container_view_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/clean/chrome/browser/ui/root/root_container_view_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/tab/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab/tab_container_view_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/tab/tab_coordinator.mm View 2 chunks +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/toolbar/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/tools/BUILD.gn View 3 chunks +2 lines, -4 lines 0 comments Download
M ios/clean/chrome/browser/ui/tools/tools_coordinator.mm View 3 chunks +3 lines, -3 lines 0 comments Download
D ios/clean/chrome/browser/ui/tools/tools_menu_transition_controller.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ios/clean/chrome/browser/ui/tools/tools_menu_transition_controller.mm View 1 chunk +0 lines, -36 lines 0 comments Download
A ios/clean/chrome/browser/ui/transitions/BUILD.gn View 1 chunk +20 lines, -0 lines 0 comments Download
A + ios/clean/chrome/browser/ui/transitions/animators/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
A + ios/clean/chrome/browser/ui/transitions/animators/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ios/clean/chrome/browser/ui/transitions/animators/zoom_transition_animator.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ios/clean/chrome/browser/ui/transitions/animators/zoom_transition_animator.mm View 1 chunk +1 line, -1 line 0 comments Download
A + ios/clean/chrome/browser/ui/transitions/animators/zoom_transition_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/clean/chrome/browser/ui/transitions/presenters/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ios/clean/chrome/browser/ui/transitions/presenters/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ios/clean/chrome/browser/ui/transitions/presenters/menu_presentation_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/clean/chrome/browser/ui/transitions/presenters/menu_presentation_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A ios/clean/chrome/browser/ui/transitions/presenters/menu_presentation_delegate.h View 1 chunk +20 lines, -0 lines 0 comments Download
A + ios/clean/chrome/browser/ui/transitions/zoom_transition_controller.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ios/clean/chrome/browser/ui/transitions/zoom_transition_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + ios/clean/chrome/browser/ui/transitions/zooming_menu_transition_controller.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ios/clean/chrome/browser/ui/transitions/zooming_menu_transition_controller.mm View 2 chunks +5 lines, -5 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 13 (9 generated)
sczs
PTAL Lots of files, but easy to review! :)
3 weeks, 4 days ago (2017-06-27 00:17:25 UTC) #5
lpromero
lgtm Thanks!
3 weeks, 4 days ago (2017-06-27 09:31:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955033002/1
3 weeks, 4 days ago (2017-06-27 09:32:03 UTC) #10
commit-bot: I haz the power
3 weeks, 4 days ago (2017-06-27 09:37:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd56994a6694d1f3830b5ef89206...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973