[Telemetry] Stop existing browser after command line flags are set

[Telemetry] Stop existing browser after command line flags are set

It is possible that some Android process launches Chrome before we set
our command line flags. By writing the flags before closing any
previous Chrome instance, we ensure they are read when the process is
restarted by whatever means.

BUG=chromium:736516
Review-Url: https://codereview.chromium.org/2954923002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6af9db22b57c2cc3ee0f132ce50af8bb9a11f130

[perezju, 2017-06-26 13:31:20]

perezju@chromium.org changed reviewers:
+ nednguyen@google.com, primiano@chromium.org

[nednguyen, 2017-06-26 13:33:32]

lgtm

Do you think it's possible to set up some mock test to assert the order here?

[perezju, 2017-06-26 14:04:08]

On 2017/06/26 at 13:33:32, nednguyen wrote:
> lgtm
> 
> Do you think it's possible to set up some mock test to assert the order here?

I think that would be a very ad-hoc test. Hopefully the comment I left on the
code will warn and prevent anyone from changing the order by accident.

[perezju, 2017-06-26 14:04:13]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2017-06-26 14:04:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 14:28:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498485853948810, "parent_rev":
"b4eb70c319cb0f38d1a7764e7d9fb56dc96f8bcf", "commit_rev":
"6af9db22b57c2cc3ee0f132ce50af8bb9a11f130"}

[commit-bot: I haz the power, 2017-06-26 14:28:58]

Description was changed from

==========
[Telemetry] Stop existing browser after command line flags are set

It is possible that some Android process launches Chrome before we set
our command line flags. By writing the flags before closing any
previous Chrome instance, we ensure they are read when the process is
restarted by whatever means.

BUG=chromium:736516
==========

to

==========
[Telemetry] Stop existing browser after command line flags are set

It is possible that some Android process launches Chrome before we set
our command line flags. By writing the flags before closing any
previous Chrome instance, we ensure they are read when the process is
restarted by whatever means.

BUG=chromium:736516

Review-Url: https://codereview.chromium.org/2954923002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-06-26 14:28:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...