Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

Issue 2954923002: [Telemetry] Stop existing browser after command line flags are set (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/backends/chrome/android_browser_backend.py
diff --git a/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py
index 2cd2f81e1ab2d5269845330694ce3401f5625ae7..5921f79bfcc0005453ba7b933c3fb9e049671640 100644
--- a/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py
+++ b/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py
@@ -44,19 +44,6 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
self._saved_sslflag = ''
self._app_ui = None
- # Stop old browser, if any.
- self._StopBrowser()
-
- if self.device.HasRoot() or self.device.NeedsSU():
- if self.browser_options.profile_dir:
- self.platform_backend.PushProfile(
- self._backend_settings.package,
- self.browser_options.profile_dir)
- elif not self.browser_options.dont_override_profile:
- self.platform_backend.RemoveProfile(
- self._backend_settings.package,
- self._backend_settings.profile_ignore_list)
-
# Set the debug app if needed.
self.platform_backend.SetDebugApp(self._backend_settings.package)
@@ -102,6 +89,21 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
command_line_name = self._backend_settings.command_line_name
with flag_changer.CustomCommandLineFlags(
self.device, command_line_name, browser_startup_args):
+ # Stop existing browser, if any. This is done *after* setting the
+ # command line flags, in case some other Android process manages to
+ # trigger Chrome's startup before we do.
+ self._StopBrowser()
+
+ if self.device.HasRoot() or self.device.NeedsSU():
+ if self.browser_options.profile_dir:
+ self.platform_backend.PushProfile(
+ self._backend_settings.package,
+ self.browser_options.profile_dir)
+ elif not self.browser_options.dont_override_profile:
+ self.platform_backend.RemoveProfile(
+ self._backend_settings.package,
+ self._backend_settings.profile_ignore_list)
+
self.device.StartActivity(
intent.Intent(package=self._backend_settings.package,
activity=self._backend_settings.activity,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698