Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2954703002: win/clang: Remove -Wno-microsoft-enum-value. (Closed)

Created:
3 years, 6 months ago by Nico
Modified:
3 years, 6 months ago
Reviewers:
hans
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

win/clang: Remove -Wno-microsoft-enum-value. The warning is no longer enabled by default in clang; no need to disable it. BUG=505296 Review-Url: https://codereview.chromium.org/2954703002 Cr-Commit-Position: refs/heads/master@{#482010} Committed: https://chromium.googlesource.com/chromium/src/+/fbc74507346bb5e3ce3c0808d7d4e3e3edab1aa6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Nico
Hollow victories ring twice as loud (due to better resonance)
3 years, 6 months ago (2017-06-23 18:56:43 UTC) #4
hans
lgtm
3 years, 6 months ago (2017-06-23 18:58:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954703002/1
3 years, 6 months ago (2017-06-23 18:58:36 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 20:35:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fbc74507346bb5e3ce3c0808d7d4...

Powered by Google App Engine
This is Rietveld 408576698