Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2954703002: win/clang: Remove -Wno-microsoft-enum-value. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/compiler/compiler.gni") 8 import("//build/config/compiler/compiler.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 1047 matching lines...) Expand 10 before | Expand all | Expand 10 after
1058 if (!msvs_xtree_patched && 1058 if (!msvs_xtree_patched &&
1059 exec_script("../../win_is_xtree_patched.py", [], "value") == 0) { 1059 exec_script("../../win_is_xtree_patched.py", [], "value") == 0) {
1060 cflags += [ "/wd4702" ] # Unreachable code. 1060 cflags += [ "/wd4702" ] # Unreachable code.
1061 } 1061 }
1062 1062
1063 # Building with Clang on Windows is a work in progress and very 1063 # Building with Clang on Windows is a work in progress and very
1064 # experimental. See crbug.com/82385. 1064 # experimental. See crbug.com/82385.
1065 if (is_clang) { 1065 if (is_clang) {
1066 cflags += [ 1066 cflags += [
1067 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657 1067 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657
1068 "-Wno-microsoft-enum-value", # http://crbug.com/505296
1069 "-Wno-unknown-pragmas", # http://crbug.com/505314 1068 "-Wno-unknown-pragmas", # http://crbug.com/505314
1070 "-Wno-microsoft-cast", # http://crbug.com/550065 1069 "-Wno-microsoft-cast", # http://crbug.com/550065
1071 "-Wno-microsoft-enum-forward-reference", # http://crbug.com/718880 1070 "-Wno-microsoft-enum-forward-reference", # http://crbug.com/718880
1072 ] 1071 ]
1073 } 1072 }
1074 } else { 1073 } else {
1075 if (is_mac && !is_nacl) { 1074 if (is_mac && !is_nacl) {
1076 # When compiling Objective-C, warns if a method is used whose 1075 # When compiling Objective-C, warns if a method is used whose
1077 # availability is newer than the deployment target. This is not 1076 # availability is newer than the deployment target. This is not
1078 # required when compiling Chrome for iOS. 1077 # required when compiling Chrome for iOS.
(...skipping 726 matching lines...) Expand 10 before | Expand all | Expand 10 after
1805 1804
1806 if (is_ios || is_mac) { 1805 if (is_ios || is_mac) {
1807 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1806 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1808 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1807 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1809 config("enable_arc") { 1808 config("enable_arc") {
1810 common_flags = [ "-fobjc-arc" ] 1809 common_flags = [ "-fobjc-arc" ]
1811 cflags_objc = common_flags 1810 cflags_objc = common_flags
1812 cflags_objcc = common_flags 1811 cflags_objcc = common_flags
1813 } 1812 }
1814 } 1813 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698