Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2954663003: customtabs: Add support for speculated_url in the benchmark scripts. (Closed)

Created:
3 years, 6 months ago by Benoit L
Modified:
3 years, 6 months ago
Reviewers:
pasko
CC:
chromium-reviews, gabadie+watch_chromium.org, lizeb+watch-android-loading_chromium.org, mikecase+watch_chromium.org, devtools-reviews_chromium.org, agrieve+watch_chromium.org, jbudorick+watch_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Add support for speculated_url in the benchmark scripts. In https://codereview.chromium.org/2946913002/, a new parameter speculated_url has been added to the benchmark app to allow a different URL in mayLaunchUrl() for Custom Tabs vs the intent launched. This adds it to the benchmark script. This is required to realistically benchmark the hidden tab use cases. Also updates imports in tools/android/loading scripts. Review-Url: https://codereview.chromium.org/2954663003 Cr-Commit-Position: refs/heads/master@{#482220} Committed: https://chromium.googlesource.com/chromium/src/+/47f780db4c91da34e4c2954b0945a8642914c0d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py View 5 chunks +12 lines, -5 lines 0 comments Download
M tools/android/loading/device_setup.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/android/loading/devtools_monitor.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/android/loading/sandwich_metrics.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Benoit L
3 years, 6 months ago (2017-06-23 15:56:03 UTC) #4
pasko
lgtm for this change. Please provide more context, preferably in the commit description, such as: ...
3 years, 6 months ago (2017-06-23 16:14:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954663003/1
3 years, 6 months ago (2017-06-26 09:35:02 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-26 09:47:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/47f780db4c91da34e4c2954b0945...

Powered by Google App Engine
This is Rietveld 408576698