Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2946913002: customtabs: Update the benchmark app for hidden tab benchmarking. (Closed)

Created:
3 years, 6 months ago by Benoit L
Modified:
3 years, 6 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Update the benchmark app for hidden tab benchmarking. This sets up Custom Tabs for hidden tab benchmarking: - Force the prerendering mode - Force prerendering on cellular - Optionally set a different speculated URL and launched URL Also removes support for no state prefetch and speculative prefetch testing. Review-Url: https://codereview.chromium.org/2946913002 Cr-Commit-Position: refs/heads/master@{#481844} Committed: https://chromium.googlesource.com/chromium/src/+/20fcec1a609afad7974c0b32f1dc3615a8d26944

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -52 lines) Patch
M tools/android/customtabs_benchmark/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java View 8 chunks +66 lines, -48 lines 0 comments Download
M tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Benoit L
3 years, 6 months ago (2017-06-20 17:05:44 UTC) #2
Yusuf
lgtm
3 years, 6 months ago (2017-06-22 19:41:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946913002/1
3 years, 6 months ago (2017-06-23 08:44:13 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 10:31:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20fcec1a609afad7974c0b32f1dc...

Powered by Google App Engine
This is Rietveld 408576698