Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart

Issue 2954463002: Refactoring to prepare for kernel based jump targets (Closed)
Patch Set: Updated cf. comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart
index 2a2d94411b6d5519cd844981b6aeaefbadb17731..870ccaa324261fbd4488708cb24dd27006b19c4c 100644
--- a/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart
@@ -197,7 +197,7 @@ class ClassEmitter extends CodeEmitterHelper {
if (fieldElement.isTopLevel ||
backend.mirrorsData
.isClassAccessibleByReflection(fieldElement.enclosingClass)) {
- // TODO(johnniwinther): Support field entities.
+ // TODO(redemption): Support field entities.
FieldElement element = fieldElement;
ResolutionDartType type = element.type;
fieldNameParts.add(task.metadataCollector.reifyType(type));
@@ -320,7 +320,7 @@ class ClassEmitter extends CodeEmitterHelper {
}
if (backend.mirrorsData.isClassAccessibleByReflection(classEntity)) {
- // TODO(johnniwinther): Handle class entities.
+ // TODO(redemption): Handle class entities.
ClassElement classElement = classEntity;
List<ResolutionDartType> typeVars = classElement.typeVariables;
Iterable typeVariableProperties =
@@ -374,7 +374,7 @@ class ClassEmitter extends CodeEmitterHelper {
// TODO(herhut): Fix use of reflection name here.
enclosingBuilder.addPropertyByName("+$reflectionName", js.number(0));
} else {
- // TODO(johnniwinther): Handle class entities.
+ // TODO(redemption): Handle class entities.
ClassElement classElement = classEntity;
List<jsAst.Expression> types = <jsAst.Expression>[];
if (classElement.supertype != null) {
« no previous file with comments | « pkg/compiler/lib/src/js_backend/namer.dart ('k') | pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698