BackgroundSync: Convert to base::BindOnce/OnceCallback/OnceClosure

BackgroundSync: Convert to base::BindOnce/OnceCallback/OnceClosure

Be explicit about the expectations for callbacks passed around
as either "once" or "repeating".

base: :AdaptCallbackForRepeating() is used as necessary when calling
Review-Url: https://codereview.chromium.org/2954433002
Cr-Commit-Position: refs/heads/master@{#482747}
Committed: https://chromium.googlesource.com/chromium/src/+/64500c1e30d83c949f68d560b898d2c6274b9f73

[jsbell, 2017-06-22 00:22:34]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 00:22:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 02:32:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 02:32:30]

Dry run: This issue passed the CQ dry run.

[jsbell, 2017-06-22 17:27:12]

jsbell@chromium.org changed reviewers:
+ jkarlin@chromium.org, tzik@chromium.org

[jsbell, 2017-06-22 17:27:13]

tzik@ - can you review for "Once" correctness/style?

jkarlin@ - can you review as background_sync owner?

[tzik, 2017-06-23 16:43:36]

lgtm

[jkarlin, 2017-06-26 16:45:28]

lgtm!

https://codereview.chromium.org/2954433002/diff/1/content/browser/background_...
File content/browser/background_sync/background_sync_service_impl_unittest.cc
(right):

https://codereview.chromium.org/2954433002/diff/1/content/browser/background_...
content/browser/background_sync/background_sync_service_impl_unittest.cc:249:
bool getregistrations_called = false;
Can you rename this to get_registrations_called while you're here?

[jsbell, 2017-06-26 17:28:33]

https://codereview.chromium.org/2954433002/diff/1/content/browser/background_...
File content/browser/background_sync/background_sync_service_impl_unittest.cc
(right):

https://codereview.chromium.org/2954433002/diff/1/content/browser/background_...
content/browser/background_sync/background_sync_service_impl_unittest.cc:249:
bool getregistrations_called = false;
On 2017/06/26 16:45:28, jkarlin_slow wrote:
> Can you rename this to get_registrations_called while you're here?

Done.

[jsbell, 2017-06-26 17:28:37]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2017-06-26 17:28:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkarlin@chromium.org, tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2954433002/#ps20001
(title: "rename local variable")

[commit-bot: I haz the power, 2017-06-26 17:28:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 17:36:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 17:36:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jsbell, 2017-06-26 18:22:47]

jsbell@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[jsbell, 2017-06-26 18:22:47]

phajdan.jr@ - can you OWNERS review for content/test ?

[Paweł Hajdan Jr., 2017-06-27 18:15:31]

content/test LGTM

[jsbell, 2017-06-27 18:52:56]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2017-06-27 18:53:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 21:16:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498589576050140,
"parent_rev": "8d890ab33ea80c5a4b903f7717c77043525088ab", "commit_rev":
"64500c1e30d83c949f68d560b898d2c6274b9f73"}

[commit-bot: I haz the power, 2017-06-27 21:16:56]

Description was changed from

==========
BackgroundSync: Convert to base::BindOnce/OnceCallback/OnceClosure

Be explicit about the expectations for callbacks passed around
as either "once" or "repeating".

base::AdaptCallbackForRepeating() is used as necessary when calling
into APIs with callbacks that are logically OnceCallback but where the
callee has not been updated.
==========

to

==========
BackgroundSync: Convert to base::BindOnce/OnceCallback/OnceClosure

Be explicit about the expectations for callbacks passed around
as either "once" or "repeating".

base: :AdaptCallbackForRepeating() is used as necessary when calling
Review-Url: https://codereview.chromium.org/2954433002
Cr-Commit-Position: refs/heads/master@{#482747}
Committed:
https://chromium.googlesource.com/chromium/src/+/64500c1e30d83c949f68d560b898...
==========

[commit-bot: I haz the power, 2017-06-27 21:16:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/64500c1e30d83c949f68d560b898...