Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Unified Diff: content/browser/background_sync/background_sync_service_impl_unittest.cc

Issue 2954433002: BackgroundSync: Convert to base::BindOnce/OnceCallback/OnceClosure (Closed)
Patch Set: rename local variable Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_sync/background_sync_service_impl_unittest.cc
diff --git a/content/browser/background_sync/background_sync_service_impl_unittest.cc b/content/browser/background_sync/background_sync_service_impl_unittest.cc
index 72a64581ae339e33fe9f4b82ee839b788b6a7e8f..e70bbd4001f2dd2f5009cdaaaa8f1f820b369232 100644
--- a/content/browser/background_sync/background_sync_service_impl_unittest.cc
+++ b/content/browser/background_sync/background_sync_service_impl_unittest.cc
@@ -164,14 +164,15 @@ class BackgroundSyncServiceImplTest : public testing::Test {
bool called = false;
embedded_worker_helper_->context()->RegisterServiceWorker(
GURL(kServiceWorkerPattern), GURL(kServiceWorkerScript), NULL,
- base::Bind(&RegisterServiceWorkerCallback, &called,
- &sw_registration_id_));
+ base::AdaptCallbackForRepeating(base::BindOnce(
+ &RegisterServiceWorkerCallback, &called, &sw_registration_id_)));
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(called);
embedded_worker_helper_->context_wrapper()->FindReadyRegistrationForId(
sw_registration_id_, GURL(kServiceWorkerPattern).GetOrigin(),
- base::Bind(FindServiceWorkerRegistrationCallback, &sw_registration_));
+ base::AdaptCallbackForRepeating(base::BindOnce(
+ FindServiceWorkerRegistrationCallback, &sw_registration_)));
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(sw_registration_);
}
@@ -224,8 +225,9 @@ TEST_F(BackgroundSyncServiceImplTest, Register) {
bool called = false;
blink::mojom::BackgroundSyncError error;
blink::mojom::SyncRegistrationPtr reg;
- Register(default_sync_registration_.Clone(),
- base::Bind(&ErrorAndRegistrationCallback, &called, &error, &reg));
+ Register(
+ default_sync_registration_.Clone(),
+ base::BindOnce(&ErrorAndRegistrationCallback, &called, &error, &reg));
EXPECT_TRUE(called);
EXPECT_EQ(blink::mojom::BackgroundSyncError::NONE, error);
EXPECT_EQ("", reg->tag);
@@ -235,8 +237,8 @@ TEST_F(BackgroundSyncServiceImplTest, GetRegistrations) {
bool called = false;
blink::mojom::BackgroundSyncError error;
unsigned long array_size = 0UL;
- GetRegistrations(base::Bind(&ErrorAndRegistrationListCallback, &called,
- &error, &array_size));
+ GetRegistrations(base::BindOnce(&ErrorAndRegistrationListCallback, &called,
+ &error, &array_size));
EXPECT_TRUE(called);
EXPECT_EQ(blink::mojom::BackgroundSyncError::NONE, error);
EXPECT_EQ(0UL, array_size);
@@ -244,20 +246,20 @@ TEST_F(BackgroundSyncServiceImplTest, GetRegistrations) {
TEST_F(BackgroundSyncServiceImplTest, GetRegistrationsWithRegisteredSync) {
bool register_called = false;
- bool getregistrations_called = false;
+ bool get_registrations_called = false;
blink::mojom::BackgroundSyncError register_error;
blink::mojom::BackgroundSyncError getregistrations_error;
blink::mojom::SyncRegistrationPtr register_reg;
unsigned long array_size = 0UL;
Register(default_sync_registration_.Clone(),
- base::Bind(&ErrorAndRegistrationCallback, &register_called,
- &register_error, &register_reg));
+ base::BindOnce(&ErrorAndRegistrationCallback, &register_called,
+ &register_error, &register_reg));
EXPECT_TRUE(register_called);
EXPECT_EQ(blink::mojom::BackgroundSyncError::NONE, register_error);
- GetRegistrations(base::Bind(&ErrorAndRegistrationListCallback,
- &getregistrations_called, &getregistrations_error,
- &array_size));
- EXPECT_TRUE(getregistrations_called);
+ GetRegistrations(base::BindOnce(&ErrorAndRegistrationListCallback,
+ &get_registrations_called,
+ &getregistrations_error, &array_size));
+ EXPECT_TRUE(get_registrations_called);
EXPECT_EQ(blink::mojom::BackgroundSyncError::NONE, getregistrations_error);
EXPECT_EQ(1UL, array_size);
}

Powered by Google App Engine
This is Rietveld 408576698