Support rich line output in both speech and braille

Support rich line output in both speech and braille

- scope rich output to only when moving to new line
- this excludes character, word, selection movement and change
- indicate bold, italic, underline in braille based on the current braille table
- indicate all rich annotations in speech
- do not indicate all rich annotations in braille; the large amount of output clutters the display; need alternate form/impl.

TEST=editing_test and manually for various tables.
BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2954413003
Cr-Commit-Position: refs/heads/master@{#483063}
Committed: https://chromium.googlesource.com/chromium/src/+/aa5ea5a7134eef78d614541e209285e78705cd71

[David Tseng, 2017-06-26 23:35:55]

Description was changed from

==========
Support rich line output in both speech and braille

- scope rich output to only when moving to new line
- this excludes character, word, selection movement and change
- indicate bold, italic, underline in braille based on the current braille table

TEST=editing_test and manually for various tables.
BUG=
==========

to

==========
Support rich line output in both speech and braille

- scope rich output to only when moving to new line
- this excludes character, word, selection movement and change
- indicate bold, italic, underline in braille based on the current braille table

TEST=editing_test and manually for various tables.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-06-26 23:37:03]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2017-06-26 23:37:04]

Somewhat re-introducing this for speech (in a limited form when navigating by
line) and newly for braille using liblouis' built-in support for text styles.

[David Tseng, 2017-06-26 23:38:20]

Description was changed from

==========
Support rich line output in both speech and braille

- scope rich output to only when moving to new line
- this excludes character, word, selection movement and change
- indicate bold, italic, underline in braille based on the current braille table

TEST=editing_test and manually for various tables.
BUG=
==========

to

==========
Support rich line output in both speech and braille

- scope rich output to only when moving to new line
- this excludes character, word, selection movement and change
- indicate bold, italic, underline in braille based on the current braille table
- indicate all rich annotations in speech
- do not indicate all rich annotations in braille; the large amount of output
clutters the display; need alternate form/impl.

TEST=editing_test and manually for various tables.
BUG=
==========

[David Tseng, 2017-06-26 23:59:25]

Description was changed from

==========
Support rich line output in both speech and braille

- scope rich output to only when moving to new line
- this excludes character, word, selection movement and change
- indicate bold, italic, underline in braille based on the current braille table
- indicate all rich annotations in speech
- do not indicate all rich annotations in braille; the large amount of output
clutters the display; need alternate form/impl.

TEST=editing_test and manually for various tables.
BUG=
==========

to

==========
Support rich line output in both speech and braille

- scope rich output to only when moving to new line
- this excludes character, word, selection movement and change
- indicate bold, italic, underline in braille based on the current braille table
- indicate all rich annotations in speech
- do not indicate all rich annotations in braille; the large amount of output
clutters the display; need alternate form/impl.

TEST=editing_test and manually for various tables.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-06-27 00:00:23]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 00:00:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-06-27 21:21:53]

lgtm

https://codereview.chromium.org/2954413003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/braille/spans.js (right):

https://codereview.chromium.org/2954413003/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/braille/spans.js:84: cvox.FormSpan =
function(formType) {
The word "form" has other meanings. formType or typeForm are both used in the
liblouis api so it makes sense to use that, even though they're confusing - but
cvox.FormSpan is our own abstraction so how about naming it something more
verbose and easier to understand.

Maybe cvox.BrailleTextStyleSpan or something like that?

https://codereview.chromium.org/2954413003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
(right):

https://codereview.chromium.org/2954413003/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js:420: var
parent = span.parent;
Rather than always checking the parent, I'd only go to the parent
if the current role is inline text box. Then I wouldn't bother
returning if the parent is not static text, because any element
can have a style. For example, it probably makes sense to underline
a whole link, not just the text of a link

[David Tseng, 2017-06-27 23:48:18]

On 2017/06/27 21:21:53, dmazzoni wrote:
> lgtm
> 
>
https://codereview.chromium.org/2954413003/diff/40001/chrome/browser/resource...
> File chrome/browser/resources/chromeos/chromevox/braille/spans.js (right):
> 
>
https://codereview.chromium.org/2954413003/diff/40001/chrome/browser/resource...
> chrome/browser/resources/chromeos/chromevox/braille/spans.js:84: cvox.FormSpan
=
> function(formType) {
> The word "form" has other meanings. formType or typeForm are both used in the
> liblouis api so it makes sense to use that, even though they're confusing -
but
> cvox.FormSpan is our own abstraction so how about naming it something more
> verbose and easier to understand.
> 
> Maybe cvox.BrailleTextStyleSpan or something like that?
> 
>
https://codereview.chromium.org/2954413003/diff/40001/chrome/browser/resource...
> File chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
> (right):
> 
>
https://codereview.chromium.org/2954413003/diff/40001/chrome/browser/resource...
> chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js:420:
var
> parent = span.parent;
> Rather than always checking the parent, I'd only go to the parent
> if the current role is inline text box. Then I wouldn't bother
> returning if the parent is not static text, because any element
> can have a style. For example, it probably makes sense to underline
> a whole link, not just the text of a link

now doing something like
var style = span.role == RoleType.INLINE_TEXT_BOX ? span.parent : span;

[David Tseng, 2017-06-27 23:52:41]

Added a test as well. I forgot that style indicators in at least old school g2
english braille start at the first word in the style span and at the beginning
of the last word
e.g.
this |is a |test
means
is a test
is bolded.

Seems to work in liblouis correctly for old g2 and ueb, so hopefully they're
getting the rules right for other languages.

https://codereview.chromium.org/2954413003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/braille/spans.js (right):

https://codereview.chromium.org/2954413003/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/braille/spans.js:84: cvox.FormSpan =
function(formType) {
On 2017/06/27 21:21:52, dmazzoni wrote:
> The word "form" has other meanings. formType or typeForm are both used in the
> liblouis api so it makes sense to use that, even though they're confusing -
but
> cvox.FormSpan is our own abstraction so how about naming it something more
> verbose and easier to understand.
> 
> Maybe cvox.BrailleTextStyleSpan or something like that?

The spans are really only useful for liblouis, but agreed on readability. Done.

https://codereview.chromium.org/2954413003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
(right):

https://codereview.chromium.org/2954413003/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js:420: var
parent = span.parent;
On 2017/06/27 21:21:52, dmazzoni wrote:
> Rather than always checking the parent, I'd only go to the parent
> if the current role is inline text box. Then I wouldn't bother
> returning if the parent is not static text, because any element
> can have a style. For example, it probably makes sense to underline
> a whole link, not just the text of a link

Acknowledged.

[David Tseng, 2017-06-28 00:27:27]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 00:27:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 01:45:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 01:45:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2017-06-28 06:53:23]

Description was changed from

==========
Support rich line output in both speech and braille

- scope rich output to only when moving to new line
- this excludes character, word, selection movement and change
- indicate bold, italic, underline in braille based on the current braille table
- indicate all rich annotations in speech
- do not indicate all rich annotations in braille; the large amount of output
clutters the display; need alternate form/impl.

TEST=editing_test and manually for various tables.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Support rich line output in both speech and braille

- scope rich output to only when moving to new line
- this excludes character, word, selection movement and change
- indicate bold, italic, underline in braille based on the current braille table
- indicate all rich annotations in speech
- do not indicate all rich annotations in braille; the large amount of output
clutters the display; need alternate form/impl.

TEST=editing_test and manually for various tables.
BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-06-28 06:54:06]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2017-06-28 06:54:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2954413003/#ps80001
(title: "Fix Liblouis tests.")

[commit-bot: I haz the power, 2017-06-28 06:54:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 08:12:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 08:12:18]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2017-06-28 16:46:22]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2017-06-28 16:46:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2954413003/#ps100001
(title: "Fix browser test")

[commit-bot: I haz the power, 2017-06-28 16:46:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 18:12:21]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1498668382332640,
"parent_rev": "373c86f2c5469d8d8de08437e5bcdf377ccd4a92", "commit_rev":
"29c56d10bc8a75f78e3847ddc7718196e728d532"}

[commit-bot: I haz the power, 2017-06-28 18:12:36]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1498668382332640,
"parent_rev": "c97be785b3d8cbb1d0d831c80c9401d108bde061", "commit_rev":
"aa5ea5a7134eef78d614541e209285e78705cd71"}

[commit-bot: I haz the power, 2017-06-28 18:12:53]

Description was changed from

==========
Support rich line output in both speech and braille

- scope rich output to only when moving to new line
- this excludes character, word, selection movement and change
- indicate bold, italic, underline in braille based on the current braille table
- indicate all rich annotations in speech
- do not indicate all rich annotations in braille; the large amount of output
clutters the display; need alternate form/impl.

TEST=editing_test and manually for various tables.
BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Support rich line output in both speech and braille

- scope rich output to only when moving to new line
- this excludes character, word, selection movement and change
- indicate bold, italic, underline in braille based on the current braille table
- indicate all rich annotations in speech
- do not indicate all rich annotations in braille; the large amount of output
clutters the display; need alternate form/impl.

TEST=editing_test and manually for various tables.
BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2954413003
Cr-Commit-Position: refs/heads/master@{#483063}
Committed:
https://chromium.googlesource.com/chromium/src/+/aa5ea5a7134eef78d614541e2092...
==========

[commit-bot: I haz the power, 2017-06-28 18:12:57]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/aa5ea5a7134eef78d614541e2092...