Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3053)

Unified Diff: chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js

Issue 2954413003: Support rich line output in both speech and braille (Closed)
Patch Set: Fix browser test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator_test.unitjs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js
diff --git a/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js b/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js
index bbbe5804a5a9845e5e4849e398af4af379e38ff7..1402c3f44f86580779b0df5814125827644c5665 100644
--- a/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js
+++ b/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js
@@ -96,9 +96,17 @@ cvox.ExpandingBrailleTranslator.prototype.translate = function(
var extraCellsPositions = extraCellsSpans.map(function(span) {
return text.getSpanStart(span);
});
+ var formTypeMap = new Array(text.length).fill(0);
+ text.getSpansInstanceOf(cvox.BrailleTextStyleSpan).forEach(function(span) {
+ var start = text.getSpanStart(span);
+ var end = text.getSpanEnd(span);
+ for (var i = start; i < end; i++)
+ formTypeMap[i] |= span.formType;
+ });
+
if (expandRanges.length == 0 && extraCellsSpans.length == 0) {
this.defaultTranslator_.translate(
- text.toString(),
+ text.toString(), formTypeMap,
cvox.ExpandingBrailleTranslator.nullParamsToEmptyAdapter_(
text.length, callback));
return;
@@ -180,6 +188,7 @@ cvox.ExpandingBrailleTranslator.prototype.translate = function(
chunksToTranslate.forEach(function(chunk) {
chunk.translator.translate(
text.toString().substring(chunk.start, chunk.end),
+ formTypeMap.slice(chunk.start, chunk.end),
cvox.ExpandingBrailleTranslator.nullParamsToEmptyAdapter_(
chunk.end - chunk.start, goog.partial(chunkTranslated, chunk)));
});
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator_test.unitjs » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698