Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2954353002: Add missing V8_EXPORT_PRIVATE to operator<< for OperandType (Closed)

Created:
3 years, 5 months ago by hans
Modified:
3 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Add missing V8_EXPORT_PRIVATE to operator<< for OperandType The missing export caused component build breakage when Bytecodes::SizeOfOperand was moved into the header in https://codereview.chromium.org/2950993002. BUG=none Review-Url: https://codereview.chromium.org/2954353002 Cr-Commit-Position: refs/heads/master@{#46228} Committed: https://chromium.googlesource.com/v8/v8/+/a2f51f779025adcd32fa72664591246edfcc3b9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/interpreter/bytecode-operands.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
hans
Please take a look.
3 years, 5 months ago (2017-06-26 15:44:55 UTC) #2
hans
+all the owners in case someone is around late in the office This is a ...
3 years, 5 months ago (2017-06-26 16:09:37 UTC) #4
Benedikt Meurer
lgtm
3 years, 5 months ago (2017-06-26 17:33:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954353002/1
3 years, 5 months ago (2017-06-26 17:34:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/a2f51f779025adcd32fa72664591246edfcc3b9b
3 years, 5 months ago (2017-06-26 17:35:53 UTC) #14
rmcilroy
Sorry I had left the office, LGTM too.
3 years, 5 months ago (2017-06-26 19:23:44 UTC) #15
rmcilroy
3 years, 5 months ago (2017-06-26 19:23:47 UTC) #16
Message was sent while issue was closed.
Sorry I had left the office, LGTM too.

Powered by Google App Engine
This is Rietveld 408576698