Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/interpreter/bytecode-operands.h

Issue 2954353002: Add missing V8_EXPORT_PRIVATE to operator<< for OperandType (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_INTERPRETER_BYTECODE_OPERANDS_H_ 5 #ifndef V8_INTERPRETER_BYTECODE_OPERANDS_H_
6 #define V8_INTERPRETER_BYTECODE_OPERANDS_H_ 6 #define V8_INTERPRETER_BYTECODE_OPERANDS_H_
7 7
8 #include "src/globals.h" 8 #include "src/globals.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 int result = static_cast<int>(lhs) | static_cast<int>(rhs); 123 int result = static_cast<int>(lhs) | static_cast<int>(rhs);
124 return static_cast<AccumulatorUse>(result); 124 return static_cast<AccumulatorUse>(result);
125 } 125 }
126 126
127 V8_EXPORT_PRIVATE std::ostream& operator<<(std::ostream& os, 127 V8_EXPORT_PRIVATE std::ostream& operator<<(std::ostream& os,
128 const AccumulatorUse& use); 128 const AccumulatorUse& use);
129 V8_EXPORT_PRIVATE std::ostream& operator<<(std::ostream& os, 129 V8_EXPORT_PRIVATE std::ostream& operator<<(std::ostream& os,
130 const OperandScale& operand_scale); 130 const OperandScale& operand_scale);
131 V8_EXPORT_PRIVATE std::ostream& operator<<(std::ostream& os, 131 V8_EXPORT_PRIVATE std::ostream& operator<<(std::ostream& os,
132 const OperandSize& operand_size); 132 const OperandSize& operand_size);
133 std::ostream& operator<<(std::ostream& os, const OperandType& operand_type); 133 V8_EXPORT_PRIVATE std::ostream& operator<<(std::ostream& os,
134 const OperandType& operand_type);
134 135
135 class BytecodeOperands { 136 class BytecodeOperands {
136 public: 137 public:
137 // Returns true if |accumulator_use| reads the accumulator. 138 // Returns true if |accumulator_use| reads the accumulator.
138 static constexpr bool ReadsAccumulator(AccumulatorUse accumulator_use) { 139 static constexpr bool ReadsAccumulator(AccumulatorUse accumulator_use) {
139 return accumulator_use == AccumulatorUse::kRead || 140 return accumulator_use == AccumulatorUse::kRead ||
140 accumulator_use == AccumulatorUse::kReadWrite; 141 accumulator_use == AccumulatorUse::kReadWrite;
141 } 142 }
142 143
143 // Returns true if |accumulator_use| writes the accumulator. 144 // Returns true if |accumulator_use| writes the accumulator.
(...skipping 13 matching lines...) Expand all
157 return operand_type >= OperandType::kIdx && 158 return operand_type >= OperandType::kIdx &&
158 operand_type <= OperandType::kRegCount; 159 operand_type <= OperandType::kRegCount;
159 } 160 }
160 }; 161 };
161 162
162 } // namespace interpreter 163 } // namespace interpreter
163 } // namespace internal 164 } // namespace internal
164 } // namespace v8 165 } // namespace v8
165 166
166 #endif // V8_INTERPRETER_BYTECODE_OPERANDS_H_ 167 #endif // V8_INTERPRETER_BYTECODE_OPERANDS_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698