Merge ResourceRequestBodyImpl and ResourceRequestBody.

Merge ResourceRequestBodyImpl and ResourceRequestBody.

The NetworkService's API is currently in content/common, but it needs
to be moved to content/public/common for chrome to use it.  This CL
merges ResourceRequestBodyImpl (in content/common) with
ResourceRequestBody (in content/public/common) as a step towards having
the entire API in content/public/common.

BUG=736906
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2954343005
Cr-Commit-Position: refs/heads/master@{#483527}
Committed: https://chromium.googlesource.com/chromium/src/+/947258b6d1913b7f57118386310383c896b90163

[mmenke, 2017-06-28 20:09:00]

Description was changed from

==========
.


.

BUG=
==========

to

==========
.


.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mmenke, 2017-06-28 20:16:59]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 20:17:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 20:20:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 20:20:55]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mmenke, 2017-06-28 21:19:23]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 21:19:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 21:36:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 21:36:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmenke, 2017-06-28 22:13:05]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 22:13:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 22:28:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 22:28:58]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[mmenke, 2017-06-29 01:14:26]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 01:14:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 01:31:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 01:31:55]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[mmenke, 2017-06-29 02:02:59]

Description was changed from

==========
.


.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Merge ResourceRequestBodyImpl and ResourceRequestBody.

The NetworkService's API is currently in content/common, but it needs
to be moved to content/public/common for chrome to use it.  This CL
merges ResourceRequestBodyImpl (in content/common) with
ResourceRequestBody (in content/public/common) as a step towards having
the entire API in content/public/common.

BUG=736906
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mmenke, 2017-06-29 02:15:33]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 02:15:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 02:33:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 02:33:43]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[mmenke, 2017-06-29 03:01:18]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 03:01:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 03:37:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 03:37:12]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[mmenke, 2017-06-29 03:48:33]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 03:48:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 04:53:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 04:54:00]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mmenke, 2017-06-29 15:02:21]

Patchset #6 (id:100001) has been deleted

[mmenke, 2017-06-29 15:02:33]

Patchset #3 (id:40001) has been deleted

[mmenke, 2017-06-29 15:02:46]

Patchset #3 (id:60001) has been deleted

[mmenke, 2017-06-29 15:02:59]

Patchset #3 (id:80001) has been deleted

[mmenke, 2017-06-29 15:03:10]

Patchset #2 (id:20001) has been deleted

[mmenke, 2017-06-29 15:10:47]

mmenke@chromium.org changed reviewers:
+ jam@chromium.org

[mmenke, 2017-06-29 15:10:48]

[jam]:  The only interesting changes here are in
content/common/resource_request_body_impl.* and
	content/public/common/resource_request_body.*.  Everything else is just
replacing ResourceRequestBodyImpl with ResourceRequestBody, and updating
includes.

If you want I can send this to someone else for an initial pass.  Not sure how
many other CLs like this I'll need - it may be I'll just need one for
ResourceRequest, and then one for all the Mojo files, but it's entirely possible
there will need to be a few more.

[mmenke, 2017-06-29 19:36:23]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 19:36:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-06-29 20:30:58]

lgtm

https://codereview.chromium.org/2954343005/diff/140001/content/public/common/...
File content/public/common/resource_request_body.h (right):

https://codereview.chromium.org/2954343005/diff/140001/content/public/common/...
content/public/common/resource_request_body.h:58: // All of the below methods
are only intended for use by content.
nit: no need to mention caller, this will eventually be blink as the
web_url_request_util code moves to blink

[mmenke, 2017-06-29 20:33:33]

https://codereview.chromium.org/2954343005/diff/140001/content/public/common/...
File content/public/common/resource_request_body.h (right):

https://codereview.chromium.org/2954343005/diff/140001/content/public/common/...
content/public/common/resource_request_body.h:58: // All of the below methods
are only intended for use by content.
On 2017/06/29 20:30:58, jam wrote:
> nit: no need to mention caller, this will eventually be blink as the
> web_url_request_util code moves to blink

I'll remove the comment, but note that this API will be used by chrome/ as well
- plenty of chrome code wants to upload stuff.

[mmenke, 2017-06-29 20:38:05]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2017-06-29 20:38:47]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2017-06-29 20:38:50]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2954343005/#ps160001
(title: "Remove comment")

[commit-bot: I haz the power, 2017-06-29 20:39:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 20:50:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 20:50:14]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mmenke, 2017-06-29 22:30:37]

mmenke@chromium.org changed reviewers:
+ mbarbella@chromium.org

[mmenke, 2017-06-29 22:30:38]

[+mbarbella]  Please review content/common/frame_messages.h and
content/common/resource_messages.* (Probably TBRable, but they are no parent for
a reason, I suppose, though seems weird that mojo files don't have the same
restriction)

[Martin Barbella, 2017-06-29 22:40:14]

On 2017/06/29 22:30:38, mmenke wrote:
> [+mbarbella]  Please review content/common/frame_messages.h and
> content/common/resource_messages.* (Probably TBRable, but they are no parent
for
> a reason, I suppose, though seems weird that mojo files don't have the same
> restriction)

We do actually have the same restrictions for mojom changes. Any examples where
they aren't being enforced?

IPC changes lgtm

[mmenke, 2017-06-29 22:43:47]

On 2017/06/29 22:40:14, Martin Barbella wrote:
> On 2017/06/29 22:30:38, mmenke wrote:
> > [+mbarbella]  Please review content/common/frame_messages.h and
> > content/common/resource_messages.* (Probably TBRable, but they are no parent
> for
> > a reason, I suppose, though seems weird that mojo files don't have the same
> > restriction)
> 
> We do actually have the same restrictions for mojom changes. Any examples
where
> they aren't being enforced?
> 
> IPC changes lgtm

Hrm...May well be my mistake.  It's been a while since I modified one myself, or
reviewed one being modified, so I could well be misremembering.

[mmenke, 2017-06-29 22:43:55]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-06-29 22:44:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 22:52:17]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1498776235819600,
"parent_rev": "00eb7a2dfd3224a58de38a4a202b976e7f0b118f", "commit_rev":
"947258b6d1913b7f57118386310383c896b90163"}

[commit-bot: I haz the power, 2017-06-29 22:52:32]

Description was changed from

==========
Merge ResourceRequestBodyImpl and ResourceRequestBody.

The NetworkService's API is currently in content/common, but it needs
to be moved to content/public/common for chrome to use it.  This CL
merges ResourceRequestBodyImpl (in content/common) with
ResourceRequestBody (in content/public/common) as a step towards having
the entire API in content/public/common.

BUG=736906
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Merge ResourceRequestBodyImpl and ResourceRequestBody.

The NetworkService's API is currently in content/common, but it needs
to be moved to content/public/common for chrome to use it.  This CL
merges ResourceRequestBodyImpl (in content/common) with
ResourceRequestBody (in content/public/common) as a step towards having
the entire API in content/public/common.

BUG=736906
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2954343005
Cr-Commit-Position: refs/heads/master@{#483527}
Committed:
https://chromium.googlesource.com/chromium/src/+/947258b6d1913b7f571183863103...
==========

[commit-bot: I haz the power, 2017-06-29 22:52:34]

Committed patchset #4 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/947258b6d1913b7f571183863103...