Source/core/animation/AnimatableLengthBox.h - Issue 29543005: Introduce DEFINE_ANIMATABLE_VALUE_TYPE_CASTS to replace manual toFoo() for animatable value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/AnimatableLengthBox.h

Issue 29543005: Introduce DEFINE_ANIMATABLE_VALUE_TYPE_CASTS to replace manual toFoo() for animatable value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/AnimatableLength.h ('k') | Source/core/animation/AnimatableLengthBoxAndBool.h » ('j') | Source/core/animation/AnimatableRepeatable.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/AnimatableLengthBox.h

diff --git a/Source/core/animation/AnimatableLengthBox.h b/Source/core/animation/AnimatableLengthBox.h

index f1ee0612eda97ce1c6741d6a1c8649ee9aadf4fb..b7ea5be5f6a197391e6f8578267161fc9fe8f581 100644

--- a/Source/core/animation/AnimatableLengthBox.h

+++ b/Source/core/animation/AnimatableLengthBox.h

@@ -68,11 +68,7 @@ private:

RefPtr<AnimatableValue> m_bottom;

};

-inline const AnimatableLengthBox* toAnimatableLengthBox(const AnimatableValue* value)

- ASSERT_WITH_SECURITY_IMPLICATION(value && value->isLengthBox());

- return static_cast<const AnimatableLengthBox*>(value);

+DEFINE_ANIMATABLE_VALUE_TYPE_CASTS(AnimatableLengthBox, isLengthBox());

} // namespace WebCore