Introduce DEFINE_ANIMATABLE_VALUE_TYPE_CASTS to replace manual toFoo() for animatable value

Source/core/animation/AnimatableRepeatable.h

Index: Source/core/animation/AnimatableRepeatable.h
diff --git a/Source/core/animation/AnimatableRepeatable.h b/Source/core/animation/AnimatableRepeatable.h
index 6d1747116666aac96d03d536a293179739755e93..b1c74949c11b5850d882809188069559a3c8e711 100644
--- a/Source/core/animation/AnimatableRepeatable.h
+++ b/Source/core/animation/AnimatableRepeatable.h
@@ -72,12 +72,7 @@ private:
     virtual bool equalTo(const AnimatableValue*) const OVERRIDE;
 };
 
-inline const AnimatableRepeatable* toAnimatableRepeatable(const AnimatableValue* value)
-{
-    // FIXME: Use a better typing system for AnimatableValues that doesn't require ugliness like this to support subclassing.
-    ASSERT_WITH_SECURITY_IMPLICATION(value && (value->isRepeatable() || value->isStrokeDasharrayList()));
-    return static_cast<const AnimatableRepeatable*>(value);
-}
+DEFINE_TYPE_CASTS(AnimatableRepeatable, AnimatableValue, value, (value->isRepeatable() || value->isStrokeDasharrayList()), (value.isRepeatable() || value.isStrokeDasharrayList()));

[gyuyoung-inactive, 2013/10/21 09:33:55]

Unfortunately, current DEFINE_ANIMATABLE_VALUE_TYPE_CASTS can't support multiple
assertion conditions. So, in this case, I uses DEFINE_TYPE_CASTS directly. I
wonder how do you think about this usage.

[tkent, 2013/10/21 21:48:06]

Using generic DEFINE_TYPE_CASTS is reasonable.

 
 } // namespace WebCore