Source/core/animation/AnimatableLength.h - Issue 29543005: Introduce DEFINE_ANIMATABLE_VALUE_TYPE_CASTS to replace manual toFoo() for animatable value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/AnimatableLength.h

Issue 29543005: Introduce DEFINE_ANIMATABLE_VALUE_TYPE_CASTS to replace manual toFoo() for animatable value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/AnimatableImage.h ('k') | Source/core/animation/AnimatableLengthBox.h » ('j') | Source/core/animation/AnimatableRepeatable.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/AnimatableLength.h

diff --git a/Source/core/animation/AnimatableLength.h b/Source/core/animation/AnimatableLength.h

index 51666407b3fb68ab6eb772cecd077b1776a22245..8cf6e5924bdfae3ed273d7e00bee228ba8ee2d92 100644

--- a/Source/core/animation/AnimatableLength.h

+++ b/Source/core/animation/AnimatableLength.h

@@ -152,11 +152,7 @@ private:

friend class CoreAnimationAnimatableLengthTest;

};

-inline const AnimatableLength* toAnimatableLength(const AnimatableValue* value)

- ASSERT_WITH_SECURITY_IMPLICATION(value && value->isLength());

- return static_cast<const AnimatableLength*>(value);

+DEFINE_ANIMATABLE_VALUE_TYPE_CASTS(AnimatableLength, isLength());

} // namespace WebCore

« no previous file with comments | « Source/core/animation/AnimatableImage.h ('k') | Source/core/animation/AnimatableLengthBox.h » ('j') | Source/core/animation/AnimatableRepeatable.h » ('J')