components/password_manager/core/common/password_manager_features.h - Issue 2954093002: Adding an edit button for username correction while saving new credentials for password management.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/common/password_manager_features.h

Issue 2954093002: Adding an edit button for username correction while saving new credentials for password management. (Closed)

Patch Set: Added the feature tag and edit button view Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('K') | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('k') | components/password_manager/core/common/password_manager_features.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/common/password_manager_features.h

diff --git a/components/password_manager/core/common/password_manager_features.h b/components/password_manager/core/common/password_manager_features.h

index 57a216c78897208f214fa43cd07a518cd7d550c7..ba39cbdaba52e110cd5c4e0455e0d2f611c8f3a9 100644

--- a/components/password_manager/core/common/password_manager_features.h

+++ b/components/password_manager/core/common/password_manager_features.h

@@ -21,6 +21,7 @@ extern const base::Feature kAffiliationBasedMatching;

extern const base::Feature kDropSyncCredential;

extern const base::Feature kEnableManualPasswordGeneration;

extern const base::Feature kEnablePasswordForceSaving;

+extern const base::Feature kEnableUsernameCorrection;

vasilii 2017/06/23 12:02:07 Where is it used? ;-)

irmakk 2017/06/23 12:19:56 Oh, I thought we needed this to declare it in the

vasilii 2017/06/23 12:35:19 Hmm, strange decision. Your changes should be behi

irmakk 2017/06/23 13:04:23 OH, sorry I wasn't aware I didnt add the experimen

extern const base::Feature kProtectSyncCredential;

extern const base::Feature kProtectSyncCredentialOnReauth;

extern const base::Feature kPasswordImportExport;