Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7766)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 2954093002: Adding an edit button for username correction while saving new credentials for password management. (Closed)
Patch Set: Added the feature tag and edit button view Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
index 89a651df2e9d0c7abf027460c90248b3ea5f029a..fc6ffba67a308c19c1cf40006c614c1dcbea12b1 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
@@ -288,8 +288,8 @@ void ManagePasswordsBubbleView::AutoSigninView::OnTimer() {
// ManagePasswordsBubbleView::PendingView -------------------------------------
// A view offering the user the ability to save credentials. Contains a
-// single ManagePasswordItemsView, along with a "Save Passwords" button
-// and a "Never" button.
+// single ManagePasswordItemsView, along with a "Save Passwords" button,
+// a "Never" button and an "Edit" button to edit username field.
class ManagePasswordsBubbleView::PendingView
: public views::View,
public views::ButtonListener,
@@ -309,6 +309,7 @@ class ManagePasswordsBubbleView::PendingView
ManagePasswordsBubbleView* parent_;
+ views::Button* edit_button_;
views::Button* save_button_;
views::Button* never_button_;
@@ -328,6 +329,8 @@ ManagePasswordsBubbleView::PendingView::PendingView(
item = new ManagePasswordItemsView(parent_->model(),
&parent->model()->pending_password());
}
+ edit_button_ = views::MdTextButton::CreateSecondaryUiButton(
+ this, l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_EDIT_BUTTON));
save_button_ = views::MdTextButton::CreateSecondaryUiBlueButton(
this, l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_SAVE_BUTTON));
never_button_ = views::MdTextButton::CreateSecondaryUiButton(
@@ -349,8 +352,9 @@ ManagePasswordsBubbleView::PendingView::PendingView(
}
// Button row.
- BuildColumnSet(layout, DOUBLE_BUTTON_COLUMN_SET);
- layout->StartRow(0, DOUBLE_BUTTON_COLUMN_SET);
+ BuildColumnSet(layout, TRIPLE_BUTTON_COLUMN_SET);
vasilii 2017/06/23 12:02:07 Funny that the style exists even though it was unu
irmakk 2017/06/23 12:19:56 I was surprised too, maybe they used it before and
+ layout->StartRow(0, TRIPLE_BUTTON_COLUMN_SET);
+ layout->AddView(edit_button_);
layout->AddView(save_button_);
layout->AddView(never_button_);

Powered by Google App Engine
This is Rietveld 408576698