Adding an edit button for username correction while saving new credentials for password management.

components/password_manager/core/common/password_manager_features.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_COMMON_PASSWORD_MANAGER_FEATURES_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_COMMON_PASSWORD_MANAGER_FEATURES_H_
 
 // This file defines all the base::FeatureList features for the Password Manager
 // module.
 
 #include "base/feature_list.h"
 
 namespace password_manager {
 
 namespace features {
 
 // All features in alphabetical order. The features should be documented
 // alongside the definition of their values in the .cc file.
 
 extern const base::Feature kAffiliationBasedMatching;
 extern const base::Feature kDropSyncCredential;
 extern const base::Feature kEnableManualPasswordGeneration;
 extern const base::Feature kEnablePasswordForceSaving;
+extern const base::Feature kEnableUsernameCorrection;

[vasilii, 2017/06/23 12:02:07]

Where is it used? ;-)

[irmakk, 2017/06/23 12:19:56]

Oh, I thought we needed this to declare it in the cc file but now i see it is
not really needed. :) Removed.

[vasilii, 2017/06/23 12:35:19]

Hmm, strange decision. Your changes should be behind the flag and off by default

[irmakk, 2017/06/23 13:04:23]

OH, sorry I wasn't aware I didnt add the experiment checks, added now.

 extern const base::Feature kProtectSyncCredential;
 extern const base::Feature kProtectSyncCredentialOnReauth;
 extern const base::Feature kPasswordImportExport;
 extern const base::Feature kViewPasswords;
 extern const base::Feature kFillOnAccountSelect;
 
 }  // namespace features
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_COMMON_PASSWORD_MANAGER_FEATURES_H_