Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2953943002: Revert of Enable ThinLTO for POSIX LTO by default on Linux. (Closed)

Created:
3 years, 6 months ago by pcc1
Modified:
3 years, 6 months ago
Reviewers:
hans, Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable ThinLTO for POSIX LTO by default on Linux. (patchset #2 id:20001 of https://codereview.chromium.org/2939373002/ ) Reason for revert: Breaks chromium.perf builder. BUG=735651 Original issue's description: > Enable ThinLTO for POSIX LTO by default on Linux. > > This is a reland of the remaining part of > https://codereview.chromium.org/2831213006 . > > The binary size regression has been addressed by disabling ThinLTO > whole-program optimizations and improving the quality of unoptimized > code. > > BUG=660216 > R=thakis@chromium.org,hans@chromium.org > > Review-Url: https://codereview.chromium.org/2939373002 > Cr-Commit-Position: refs/heads/master@{#480144} > Committed: https://chromium.googlesource.com/chromium/src/+/5cb9983f12f300422c16ba812c2d5cdeb278cb74 TBR=hans@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=660216 Review-Url: https://codereview.chromium.org/2953943002 Cr-Commit-Position: refs/heads/master@{#481748} Committed: https://chromium.googlesource.com/chromium/src/+/2be84dd0d41f8247d22bdc8690b5520d6c483a8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M build/toolchain/toolchain.gni View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
pcc1
Created Revert of Enable ThinLTO for POSIX LTO by default on Linux.
3 years, 6 months ago (2017-06-22 21:31:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953943002/1
3 years, 6 months ago (2017-06-22 21:31:38 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 00:47:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2be84dd0d41f8247d22bdc8690b5...

Powered by Google App Engine
This is Rietveld 408576698