Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1450)

Issue 2953613002: Stop re-adding subviews to keyboard accessory view. (Closed)

Created:
3 years, 6 months ago by jif
Modified:
3 years, 6 months ago
Reviewers:
justincohen
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop re-adding subviews to keyboard accessory view. With this CL the subviews are added only once. Also, this CL enables the experimental keyboard accessory view on iPad, as described in step 1 of https://docs.google.com/document/d/1pWfwHEeCNeWgkDjawJiDoEf93gkDV9usINcYDyXvwcY BUG=735569 Review-Url: https://codereview.chromium.org/2953613002 Cr-Commit-Position: refs/heads/master@{#481397} Committed: https://chromium.googlesource.com/chromium/src/+/4247d81a3b3dd4f3f697543c7b818ed8669e5cac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm View 2 chunks +2 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
jif
ptal
3 years, 6 months ago (2017-06-21 18:33:01 UTC) #3
justincohen
rs lgtm
3 years, 6 months ago (2017-06-22 00:03:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953613002/1
3 years, 6 months ago (2017-06-22 01:33:19 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 01:45:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4247d81a3b3dd4f3f697543c7b81...

Powered by Google App Engine
This is Rietveld 408576698