Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Issue 2953613002: Stop re-adding subviews to keyboard accessory view. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
diff --git a/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm b/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
index 315dc53cceea011ab16062b6bf80730f953c86f0..98253f2fd3a6d48f1346016ba2676055b323d491 100644
--- a/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
+++ b/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
@@ -1852,10 +1852,7 @@ CGRect RectShiftedDownAndResizedForStatusBar(CGRect rect) {
- (UIView*)keyboardAccessoryView {
if (!_keyboardAccessoryView) {
- // The new keyboard accessory view is only used on iPhones as iPads have a
- // different pattern regarding keyboard shortcuts.
- if (experimental_flags::IsKeyboardAccessoryViewWithCameraSearchEnabled() &&
- !IsIPadIdiom()) {
+ if (experimental_flags::IsKeyboardAccessoryViewWithCameraSearchEnabled()) {
// The '.' shortcut is left out because the new keyboard accessory view
// has less free space for the shortcut buttons, and the '.' is already
// present in the standard iOS keyboard.
« no previous file with comments | « ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698