Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2953553002: Reenable SiteEngagementBrowserTest.All for non-Windows platforms. (Closed)

Created:
3 years, 6 months ago by calamity
Modified:
3 years, 6 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable SiteEngagementBrowserTest.All for non-Windows platforms. BUG=734716 Review-Url: https://codereview.chromium.org/2953553002 Cr-Commit-Position: refs/heads/master@{#481158} Committed: https://chromium.googlesource.com/chromium/src/+/531ddbacfa806e9103677d34d3344e117515fdf4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/test/data/webui/engagement/site_engagement_browsertest.js View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
calamity
3 years, 6 months ago (2017-06-21 07:02:15 UTC) #2
tsergeant
lgtm
3 years, 6 months ago (2017-06-21 07:12:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953553002/1
3 years, 6 months ago (2017-06-21 07:23:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/454206)
3 years, 6 months ago (2017-06-21 08:08:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953553002/1
3 years, 6 months ago (2017-06-21 08:44:43 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 09:42:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/531ddbacfa806e9103677d34d334...

Powered by Google App Engine
This is Rietveld 408576698