Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7522)

Unified Diff: chrome/test/data/webui/engagement/site_engagement_browsertest.js

Issue 2953553002: Reenable SiteEngagementBrowserTest.All for non-Windows platforms. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/engagement/site_engagement_browsertest.js
diff --git a/chrome/test/data/webui/engagement/site_engagement_browsertest.js b/chrome/test/data/webui/engagement/site_engagement_browsertest.js
index 0efbd08beb61486187fc988f8377b83de48886f2..96d75dd2726b6875fca045ef4535633f49e1903d 100644
--- a/chrome/test/data/webui/engagement/site_engagement_browsertest.js
+++ b/chrome/test/data/webui/engagement/site_engagement_browsertest.js
@@ -46,8 +46,13 @@ SiteEngagementBrowserTest.prototype = {
},
};
-// TODO(crbug.com/734716): This test is flaky.
-TEST_F('SiteEngagementBrowserTest', 'DISABLED_All', function() {
+// This test is flaky on Windows. See https://crbug.com/734716.
+GEN('#if defined(OS_WIN)');
+GEN('#define MAYBE_All DISABLED_All');
+GEN('#else');
+GEN('#define MAYBE_All All');
+GEN('#endif');
+TEST_F('SiteEngagementBrowserTest', 'MAYBE_All', function() {
test('check engagement values are loaded', function() {
var originCells =
Array.from(document.getElementsByClassName('origin-cell'));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698