Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: content/public/browser/web_contents.h

Issue 2953513002: Fix a race between navigation and an interstitial. (Closed)
Patch Set: reword Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/interstitial_page.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index ea487a2eb0370fb7f3177d393d28dc2cf60b1151..78cd7632e64649f004ebd5705646a7c13ca5d7b1 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -562,8 +562,12 @@ class WebContents : public PageNavigator,
// Various other systems need to know about our interstitials.
virtual bool ShowingInterstitialPage() const = 0;
- // Returns the currently showing interstitial, nullptr if no interstitial is
- // showing.
+ // Returns the currently visible interstitial, nullptr if no interstitial is
+ // visible. Note: This returns nullptr from the time the interstitial page has
+ // Show() called on it until the interstitial content is ready and the
+ // interstitial is displayed.
+ //
+ // Compare to InterstitialPage::GetInterstitialPage.
virtual InterstitialPage* GetInterstitialPage() const = 0;
// Misc state & callbacks ----------------------------------------------------
« no previous file with comments | « content/public/browser/interstitial_page.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698