Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: content/public/browser/interstitial_page.h

Issue 2953513002: Fix a race between navigation and an interstitial. (Closed)
Patch Set: reword Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl_unittest.cc ('k') | content/public/browser/web_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/interstitial_page.h
diff --git a/content/public/browser/interstitial_page.h b/content/public/browser/interstitial_page.h
index e22f402985dc9c73433c3ed37639055c444a369e..bdc03b3c7b31ff01ef314baf40eb0375767ba79a 100644
--- a/content/public/browser/interstitial_page.h
+++ b/content/public/browser/interstitial_page.h
@@ -48,13 +48,16 @@ class InterstitialPage {
const GURL& url,
InterstitialPageDelegate* delegate);
- // Retrieves the InterstitialPage if any associated with the specified
- // |web_contents|.
+ // Returns the InterstitialPage, if any, associated with the specified
+ // |web_contents|. Note: This returns a value from the time the interstitial
+ // page has Show() called on it.
+ //
+ // Compare to WebContents::GetInterstitialPage.
CONTENT_EXPORT static InterstitialPage* GetInterstitialPage(
WebContents* web_contents);
- // Retrieves the InterstitialPage that hosts the RenderFrameHost, or nullptr
- // if |rfh| is not a part of any InterstitialPage.
+ // Returns the InterstitialPage that hosts the RenderFrameHost, or nullptr if
+ // |rfh| is not a part of any InterstitialPage.
CONTENT_EXPORT static InterstitialPage* FromRenderFrameHost(
RenderFrameHost* rfh);
« no previous file with comments | « content/browser/web_contents/web_contents_impl_unittest.cc ('k') | content/public/browser/web_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698