Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: content/public/browser/web_contents.h

Issue 2953513002: Fix a race between navigation and an interstitial. (Closed)
Patch Set: reword Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/browser/interstitial_page.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 544 matching lines...) Expand 10 before | Expand all | Expand 10 after
555 // Focuses the first (last if |reverse| is true) element in the page. 555 // Focuses the first (last if |reverse| is true) element in the page.
556 // Invoked when this tab is getting the focus through tab traversal (|reverse| 556 // Invoked when this tab is getting the focus through tab traversal (|reverse|
557 // is true when using Shift-Tab). 557 // is true when using Shift-Tab).
558 virtual void FocusThroughTabTraversal(bool reverse) = 0; 558 virtual void FocusThroughTabTraversal(bool reverse) = 0;
559 559
560 // Interstitials ------------------------------------------------------------- 560 // Interstitials -------------------------------------------------------------
561 561
562 // Various other systems need to know about our interstitials. 562 // Various other systems need to know about our interstitials.
563 virtual bool ShowingInterstitialPage() const = 0; 563 virtual bool ShowingInterstitialPage() const = 0;
564 564
565 // Returns the currently showing interstitial, nullptr if no interstitial is 565 // Returns the currently visible interstitial, nullptr if no interstitial is
566 // showing. 566 // visible. Note: This returns nullptr from the time the interstitial page has
567 // Show() called on it until the interstitial content is ready and the
568 // interstitial is displayed.
569 //
570 // Compare to InterstitialPage::GetInterstitialPage.
567 virtual InterstitialPage* GetInterstitialPage() const = 0; 571 virtual InterstitialPage* GetInterstitialPage() const = 0;
568 572
569 // Misc state & callbacks ---------------------------------------------------- 573 // Misc state & callbacks ----------------------------------------------------
570 574
571 // Check whether we can do the saving page operation this page given its MIME 575 // Check whether we can do the saving page operation this page given its MIME
572 // type. 576 // type.
573 virtual bool IsSavable() = 0; 577 virtual bool IsSavable() = 0;
574 578
575 // Prepare for saving the current web page to disk. 579 // Prepare for saving the current web page to disk.
576 virtual void OnSavePage() = 0; 580 virtual void OnSavePage() = 0;
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
831 835
832 private: 836 private:
833 // This interface should only be implemented inside content. 837 // This interface should only be implemented inside content.
834 friend class WebContentsImpl; 838 friend class WebContentsImpl;
835 WebContents() {} 839 WebContents() {}
836 }; 840 };
837 841
838 } // namespace content 842 } // namespace content
839 843
840 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 844 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
OLDNEW
« no previous file with comments | « content/public/browser/interstitial_page.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698