Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 2953443002: Revert of Reland: Move the files related to Android <-> Web credentials to a separate folder. (Closed)

Created:
3 years, 6 months ago by findit-for-me
Modified:
3 years, 6 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, gcasto+watchlist_chromium.org, ios-reviews_chromium.org, ios-reviews+chrome_chromium.org, jam, marq+watch_chromium.org, noyau+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Move the files related to Android <-> Web credentials to a separate folder. (patchset #2 id:20001 of https://codereview.chromium.org/2949793002/ ) Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 480867 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZmNjY1NmFiM2ExYzVmY2I2ZWQ3OGZhZTU1YjViYjk3ZjY3MmY3NWMM Original issue's description: > Reland: Move the files related to Android <-> Web credentials to a separate folder. > > Reland https://codereview.chromium.org/2949573002/ > > BUG=630555 > TBR=engedy@chromium.org > > Review-Url: https://codereview.chromium.org/2949793002 > Cr-Commit-Position: refs/heads/master@{#480867} > Committed: https://chromium.googlesource.com/chromium/src/+/ff6656ab3a1c5fcb6ed78fae55b5bb97f672f75c TBR=vabr@chromium.org,vasilii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630555 Review-Url: https://codereview.chromium.org/2953443002 Cr-Commit-Position: refs/heads/master@{#480871} Committed: https://chromium.googlesource.com/chromium/src/+/1012b8c27409e507d7a9c9038a58d4eb79309739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8306 lines, -8305 lines) Patch
M chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/password_manager_presenter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/browser/credential_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/browser/credential_manager_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 5 chunks +37 lines, -37 lines 0 comments Download
A components/password_manager/core/browser/affiliated_match_helper.h View 1 chunk +160 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliated_match_helper.cc View 1 chunk +223 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliated_match_helper_unittest.cc View 1 chunk +630 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_api.proto View 1 chunk +46 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_backend.h View 1 chunk +167 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_backend.cc View 1 chunk +294 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_backend_unittest.cc View 1 chunk +925 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_database.h View 1 chunk +93 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_database.cc View 1 chunk +266 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_database_unittest.cc View 1 chunk +309 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_fetch_throttler.h View 1 chunk +135 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_fetch_throttler.cc View 1 chunk +143 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_fetch_throttler_delegate.h View 1 chunk +29 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_fetch_throttler_unittest.cc View 1 chunk +424 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_fetcher.h View 1 chunk +99 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_fetcher.cc View 1 chunk +251 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_fetcher_delegate.h View 1 chunk +46 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_fetcher_unittest.cc View 1 chunk +337 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_service.h View 1 chunk +172 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_service.cc View 1 chunk +109 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_service_unittest.cc View 1 chunk +159 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_utils.h View 1 chunk +197 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_utils.cc View 1 chunk +314 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/affiliation_utils_unittest.cc View 1 chunk +247 lines, -0 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliated_match_helper.h View 1 chunk +0 lines, -160 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliated_match_helper.cc View 1 chunk +0 lines, -223 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliated_match_helper_unittest.cc View 1 chunk +0 lines, -630 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_api.proto View 1 chunk +0 lines, -46 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_backend.h View 1 chunk +0 lines, -167 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_backend.cc View 1 chunk +0 lines, -294 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_backend_unittest.cc View 1 chunk +0 lines, -925 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_database.h View 1 chunk +0 lines, -93 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_database.cc View 1 chunk +0 lines, -266 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_database_unittest.cc View 1 chunk +0 lines, -309 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_fetch_throttler.h View 1 chunk +0 lines, -135 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_fetch_throttler.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_fetch_throttler_delegate.h View 1 chunk +0 lines, -29 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_fetch_throttler_unittest.cc View 1 chunk +0 lines, -424 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_fetcher.h View 1 chunk +0 lines, -99 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_fetcher.cc View 1 chunk +0 lines, -251 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_fetcher_delegate.h View 1 chunk +0 lines, -46 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_fetcher_unittest.cc View 1 chunk +0 lines, -337 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_service.h View 1 chunk +0 lines, -172 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_service.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_service_unittest.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_utils.h View 1 chunk +0 lines, -196 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_utils.cc View 1 chunk +0 lines, -314 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/affiliation_utils_unittest.cc View 1 chunk +0 lines, -247 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/facet_manager.h View 1 chunk +0 lines, -137 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/facet_manager.cc View 1 chunk +0 lines, -249 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/facet_manager_host.h View 1 chunk +0 lines, -36 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/facet_manager_unittest.cc View 1 chunk +0 lines, -1522 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/fake_affiliation_api.h View 1 chunk +0 lines, -53 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/fake_affiliation_api.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/fake_affiliation_fetcher.h View 1 chunk +0 lines, -83 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/fake_affiliation_fetcher.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/mock_affiliated_match_helper.h View 1 chunk +0 lines, -64 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/mock_affiliated_match_helper.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/mock_affiliation_consumer.h View 1 chunk +0 lines, -39 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/mock_affiliation_consumer.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D components/password_manager/core/browser/android_affiliation/test_affiliation_fetcher_factory.h View 1 chunk +0 lines, -39 lines 0 comments Download
M components/password_manager/core/browser/credential_manager_pending_request_task.cc View 1 chunk +1 line, -1 line 0 comments Download
A components/password_manager/core/browser/facet_manager.h View 1 chunk +137 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/facet_manager.cc View 1 chunk +249 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/facet_manager_host.h View 1 chunk +36 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/facet_manager_unittest.cc View 1 chunk +1522 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/fake_affiliation_api.h View 1 chunk +53 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/fake_affiliation_api.cc View 1 chunk +78 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/fake_affiliation_fetcher.h View 1 chunk +83 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/fake_affiliation_fetcher.cc View 1 chunk +66 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/login_database.cc View 1 chunk +1 line, -1 line 0 comments Download
A components/password_manager/core/browser/mock_affiliated_match_helper.h View 1 chunk +64 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/mock_affiliated_match_helper.cc View 1 chunk +68 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/mock_affiliation_consumer.h View 1 chunk +39 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/mock_affiliation_consumer.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_autofill_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_store_factory_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/password_manager/core/browser/password_store_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/password_manager/core/browser/password_ui_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
A components/password_manager/core/browser/test_affiliation_fetcher_factory.h View 1 chunk +39 lines, -0 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
findit-for-me
Created Revert of Reland: Move the files related to Android <-> Web credentials to a ...
3 years, 6 months ago (2017-06-20 17:32:27 UTC) #1
findit-for-me
Sheriffs, CL owner or CL reviewers: Please confirm and "Quick L-G-T-M & CQ" this revert ...
3 years, 6 months ago (2017-06-20 17:32:29 UTC) #3
tmartino
lgtm
3 years, 6 months ago (2017-06-20 17:37:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953443002/1
3 years, 6 months ago (2017-06-20 17:38:16 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 17:39:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1012b8c27409e507d7a9c9038a58...

Powered by Google App Engine
This is Rietveld 408576698