Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: components/password_manager/core/browser/android_affiliation/affiliation_utils_unittest.cc

Issue 2953443002: Revert of Reland: Move the files related to Android <-> Web credentials to a separate folder. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/android_affiliation/affiliation_utils_unittest.cc
diff --git a/components/password_manager/core/browser/android_affiliation/affiliation_utils_unittest.cc b/components/password_manager/core/browser/android_affiliation/affiliation_utils_unittest.cc
deleted file mode 100644
index 99b32c265b9a91e1e626fcefbab7a87395e55041..0000000000000000000000000000000000000000
--- a/components/password_manager/core/browser/android_affiliation/affiliation_utils_unittest.cc
+++ /dev/null
@@ -1,247 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "components/password_manager/core/browser/android_affiliation/affiliation_utils.h"
-
-#include "base/command_line.h"
-#include "base/metrics/field_trial.h"
-#include "base/strings/utf_string_conversions.h"
-#include "components/autofill/core/common/password_form.h"
-#include "components/variations/variations_associated_data.h"
-#include "testing/gtest/include/gtest/gtest.h"
-#include "url/url_constants.h"
-
-namespace password_manager {
-
-namespace {
-const std::string kSchemeHostExample = "http://example.com";
-const char kTestFacetURI1[] = "https://alpha.example.com/";
-const char kTestFacetURI2[] = "https://beta.example.com/";
-const char kTestFacetURI3[] = "https://gamma.example.com/";
-} // namespace
-
-TEST(AffiliationUtilsTest, ValidWebFacetURIs) {
- struct {
- const char* valid_facet_uri;
- const char* expected_canonical_facet_uri;
- } kTestCases[] = {
- {"https://www.example.com", "https://www.example.com"},
- {"HTTPS://www.EXAMPLE.com", "https://www.example.com"},
- {"https://0321.0x86.161.0043", "https://209.134.161.35"},
- {"https://www.%65xample.com", "https://www.example.com"},
- {"https://sz\xc3\xb3t\xc3\xa1r.example.com",
- "https://xn--sztr-7na0i.example.com"},
- {"https://www.example.com/", "https://www.example.com"},
- {"https://www.example.com:", "https://www.example.com"},
- {"https://@www.example.com", "https://www.example.com"},
- {"https://:@www.example.com", "https://www.example.com"},
- {"https://www.example.com:8080", "https://www.example.com:8080"},
- {"https://new-gtld", "https://new-gtld"}};
- for (const auto& test_case : kTestCases) {
- SCOPED_TRACE(testing::Message("URI = ") << test_case.valid_facet_uri);
- FacetURI facet_uri =
- FacetURI::FromPotentiallyInvalidSpec(test_case.valid_facet_uri);
- ASSERT_TRUE(facet_uri.IsValidWebFacetURI());
- EXPECT_EQ(std::string(test_case.expected_canonical_facet_uri),
- facet_uri.canonical_spec());
- EXPECT_EQ(url::kHttpsScheme, facet_uri.scheme());
- EXPECT_EQ("", facet_uri.android_package_name());
- }
-}
-
-TEST(AffiliationUtilsTest, InvalidWebFacetURIs) {
- const char* kInvalidFacetURIs[]{
- // Invalid URL (actually, will be treated as having only a host part).
- "Does not look like a valid URL.",
- // Path is more than just the root path ('/').
- "https://www.example.com/path",
- // Empty scheme and not HTTPS scheme.
- "://www.example.com",
- "http://www.example.com/",
- // Forbidden non-empty components.
- "https://user@www.example.com/",
- "https://:password@www.example.com/",
- "https://www.example.com/?",
- "https://www.example.com/?query",
- "https://www.example.com/#",
- "https://www.example.com/#ref",
- // Valid Android facet URI.
- "android://hash@com.example.android"};
- for (const char* uri : kInvalidFacetURIs) {
- SCOPED_TRACE(testing::Message("URI = ") << uri);
- FacetURI facet_uri = FacetURI::FromPotentiallyInvalidSpec(uri);
- EXPECT_FALSE(facet_uri.IsValidWebFacetURI());
- }
-}
-
-TEST(AffiliationUtilsTest, ValidAndroidFacetURIs) {
- struct {
- const char* valid_facet_uri;
- const char* expected_canonical_facet_uri;
- const char* expected_package_name;
- } kTestCases[] = {
- {"android://"
- "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_"
- "@com.example.android",
- "android://"
- "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_"
- "@com.example.android",
- "com.example.android"},
- {"ANDROID://"
- "hash@abcdefghijklmnopqrstuvwxyz_0123456789.ABCDEFGHIJKLMNOPQRSTUVWXYZ",
- "android://"
- "hash@abcdefghijklmnopqrstuvwxyz_0123456789.ABCDEFGHIJKLMNOPQRSTUVWXYZ",
- "abcdefghijklmnopqrstuvwxyz_0123456789.ABCDEFGHIJKLMNOPQRSTUVWXYZ"},
- {"android://needpadding@com.example.android",
- "android://needpadding=@com.example.android",
- "com.example.android"},
- {"android://needtounescape%3D%3D@com.%65xample.android",
- "android://needtounescape==@com.example.android",
- "com.example.android"},
- {"ANDROID://hash@com.example.android",
- "android://hash@com.example.android",
- "com.example.android"},
- {"android://hash@com.example.android/",
- "android://hash@com.example.android",
- "com.example.android"},
- {"android://hash:@com.example.android",
- "android://hash@com.example.android",
- "com.example.android"}};
- for (const auto& test_case : kTestCases) {
- SCOPED_TRACE(testing::Message("URI = ") << test_case.valid_facet_uri);
- FacetURI facet_uri =
- FacetURI::FromPotentiallyInvalidSpec(test_case.valid_facet_uri);
- ASSERT_TRUE(facet_uri.IsValidAndroidFacetURI());
- EXPECT_EQ(test_case.expected_canonical_facet_uri,
- facet_uri.canonical_spec());
- EXPECT_EQ("android", facet_uri.scheme());
- EXPECT_EQ(test_case.expected_package_name,
- facet_uri.android_package_name());
- }
-}
-
-TEST(AffiliationUtilsTest, InvalidAndroidFacetURIs) {
- const char* kInvalidFacetURIs[]{
- // Invalid URL (actually, will be treated as having only a host part).
- "Does not look like a valid URL.",
- // Path is more than just the root path ('/').
- "android://hash@com.example.android/path",
- // Empty scheme or not "android" scheme.
- "://hash@com.example.android",
- "http://hash@com.example.android",
- // Package name with illegal characters.
- "android://hash@com.$example.android",
- "android://hash@com-example-android",
- "android://hash@com%2Dexample.android", // Escaped '-'.
- "android://hash@com.example.sz\xc3\xb3t\xc3\xa1r", // UTF-8 o' and a'.
- // Empty, non-existent and malformed hash part.
- "android://@com.example.android",
- "android://com.example.android",
- "android://badpadding=a@com.example.android",
- "android://toolongpaddin===@com.example.android",
- "android://invalid+characters@com.example.android",
- "android://invalid%2Fcharacters@com.example.android", // Escaped '/'.
- // Forbidden non-empty components.
- "android://hash:password@com.example.android",
- "android://hash@com.example.android:port",
- "android://hash@com.example.android/?",
- "android://hash@com.example.android/?query",
- "android://hash@com.example.android/#",
- "android://hash@com.example.android/#ref",
- // Valid Web facet URI.
- "https://www.example.com/"};
- for (const char* uri : kInvalidFacetURIs) {
- SCOPED_TRACE(testing::Message("URI = ") << uri);
- FacetURI facet_uri = FacetURI::FromPotentiallyInvalidSpec(uri);
- EXPECT_FALSE(facet_uri.IsValidAndroidFacetURI());
- EXPECT_EQ("", facet_uri.android_package_name());
- }
-}
-
-TEST(AffiliationUtilsTest, EqualEquivalenceClasses) {
- AffiliatedFacets a;
- a.push_back(FacetURI::FromCanonicalSpec(kTestFacetURI1));
- a.push_back(FacetURI::FromCanonicalSpec(kTestFacetURI2));
- a.push_back(FacetURI::FromCanonicalSpec(kTestFacetURI3));
-
- AffiliatedFacets b;
- b.push_back(FacetURI::FromCanonicalSpec(kTestFacetURI3));
- b.push_back(FacetURI::FromCanonicalSpec(kTestFacetURI1));
- b.push_back(FacetURI::FromCanonicalSpec(kTestFacetURI2));
-
- EXPECT_TRUE(AreEquivalenceClassesEqual(a, a));
- EXPECT_TRUE(AreEquivalenceClassesEqual(b, b));
- EXPECT_TRUE(AreEquivalenceClassesEqual(b, a));
- EXPECT_TRUE(AreEquivalenceClassesEqual(a, b));
-}
-
-TEST(AffiliationUtilsTest, NotEqualEquivalenceClasses) {
- AffiliatedFacets a;
- a.push_back(FacetURI::FromCanonicalSpec(kTestFacetURI1));
- a.push_back(FacetURI::FromCanonicalSpec(kTestFacetURI2));
-
- AffiliatedFacets b;
- a.push_back(FacetURI::FromCanonicalSpec(kTestFacetURI2));
- b.push_back(FacetURI::FromCanonicalSpec(kTestFacetURI3));
-
- AffiliatedFacets c;
- a.push_back(FacetURI::FromCanonicalSpec(kTestFacetURI1));
- a.push_back(FacetURI::FromCanonicalSpec(kTestFacetURI2));
- b.push_back(FacetURI::FromCanonicalSpec(kTestFacetURI3));
-
- EXPECT_FALSE(AreEquivalenceClassesEqual(a, b));
- EXPECT_FALSE(AreEquivalenceClassesEqual(a, c));
- EXPECT_FALSE(AreEquivalenceClassesEqual(b, a));
- EXPECT_FALSE(AreEquivalenceClassesEqual(b, c));
- EXPECT_FALSE(AreEquivalenceClassesEqual(c, a));
- EXPECT_FALSE(AreEquivalenceClassesEqual(c, b));
-}
-
-class GetHumanReadableOriginTest : public testing::Test {
- public:
- GetHumanReadableOriginTest() {
- form_template_.origin = GURL(kSchemeHostExample);
- form_template_.action = GURL(kSchemeHostExample);
- form_template_.username_element = base::ASCIIToUTF16("Email");
- form_template_.password_element = base::ASCIIToUTF16("Password");
- form_template_.submit_element = base::ASCIIToUTF16("signIn");
- form_template_.signon_realm = kSchemeHostExample;
- }
- const autofill::PasswordForm& form_remplate() { return form_template_; }
-
- private:
- autofill::PasswordForm form_template_;
-};
-
-TEST_F(GetHumanReadableOriginTest, OriginFromHtmlForm) {
- autofill::PasswordForm html_form(form_remplate());
- html_form.origin = GURL(kSchemeHostExample + "/LoginAuth");
- html_form.action = GURL(kSchemeHostExample + "/Login");
- html_form.scheme = autofill::PasswordForm::SCHEME_HTML;
- EXPECT_EQ(GetHumanReadableOrigin(html_form), "http://example.com");
-}
-
-TEST_F(GetHumanReadableOriginTest, OriginFromDigestForm) {
- autofill::PasswordForm non_html_form(form_remplate());
- non_html_form.scheme = autofill::PasswordForm::SCHEME_DIGEST;
- non_html_form.action = GURL();
- non_html_form.signon_realm = kSchemeHostExample + "42";
- EXPECT_EQ(GetHumanReadableOrigin(non_html_form), "http://example.com");
-}
-
-TEST_F(GetHumanReadableOriginTest, OriginFromAndroidForm) {
- autofill::PasswordForm android_form(form_remplate());
- android_form.action = GURL();
- android_form.origin = GURL();
- android_form.scheme = autofill::PasswordForm::SCHEME_OTHER;
- android_form.signon_realm =
- "android://"
- "m3HSJL1i83hdltRq0-o9czGb-8KJDKra4t_"
- "3JRlnPKcjI8PZm6XBHXx6zG4UuMXaDEZjR1wuXDre9G9zvN7AQw=="
- "@com.example.android";
- EXPECT_EQ(GetHumanReadableOrigin(android_form),
- "android://com.example.android");
-}
-
-} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698