Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2953403002: [LayoutNG] Add comments about "certain zero-height line boxes" (Closed)

Created:
3 years, 6 months ago by kojii
Modified:
3 years, 6 months ago
Reviewers:
ikilpatrick, eae
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, lchoi+reviews_chromium.org, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add comments about "certain zero-height line boxes" Found the spec section that defines "certain zero-height line boxes" do not prevent two margins being "adjoining" and thus collapsing. TBR=eae@chromium.org, ikilpatrick@chromium.org BUG=636993 NOTRY=true Review-Url: https://codereview.chromium.org/2953403002 Cr-Commit-Position: refs/heads/master@{#482167} Committed: https://chromium.googlesource.com/chromium/src/+/b1c66c859236d65da176b4fef5181a5bfd941940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
kojii
3 years, 6 months ago (2017-06-25 05:44:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953403002/1
3 years, 6 months ago (2017-06-25 05:45:01 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-25 05:48:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b1c66c859236d65da176b4fef518...

Powered by Google App Engine
This is Rietveld 408576698