Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.h

Issue 2953403002: [LayoutNG] Add comments about "certain zero-height line boxes" (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NGLineBreaker_h 5 #ifndef NGLineBreaker_h
6 #define NGLineBreaker_h 6 #define NGLineBreaker_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/layout/ng/inline/ng_inline_item_result.h" 9 #include "core/layout/ng/inline/ng_inline_item_result.h"
10 #include "core/layout/ng/inline/ng_inline_node.h" 10 #include "core/layout/ng/inline/ng_inline_node.h"
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 unsigned item_index_; 98 unsigned item_index_;
99 unsigned offset_; 99 unsigned offset_;
100 LayoutUnit position_; 100 LayoutUnit position_;
101 WTF::Optional<NGLayoutOpportunity> opportunity_; 101 WTF::Optional<NGLayoutOpportunity> opportunity_;
102 NGLogicalOffset content_offset_; 102 NGLogicalOffset content_offset_;
103 LazyLineBreakIterator break_iterator_; 103 LazyLineBreakIterator break_iterator_;
104 HarfBuzzShaper shaper_; 104 HarfBuzzShaper shaper_;
105 ShapeResultSpacing<String> spacing_; 105 ShapeResultSpacing<String> spacing_;
106 106
107 bool auto_wrap_; 107 bool auto_wrap_;
108
109 // We don't create "certain zero-height line boxes".
110 // https://drafts.csswg.org/css2/visuren.html#phantom-line-box
111 // Such line boxes do not prevent two margins being "adjoining", and thus
112 // collapsing.
113 // https://drafts.csswg.org/css2/box.html#collapsing-margins
108 bool should_create_line_box_; 114 bool should_create_line_box_;
115
109 bool is_after_forced_break_; 116 bool is_after_forced_break_;
110 }; 117 };
111 118
112 } // namespace blink 119 } // namespace blink
113 120
114 #endif // NGLineBreaker_h 121 #endif // NGLineBreaker_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698