Remove support for downloading gold plugin.

Remove support for downloading gold plugin.

Now that https://codereview.chromium.org/2957523002 has landed it
is an error to use the gold plugin (except with ChromeOS, which has
its own copy of the plugin), so we no longer need to be able to
download it. The only other user of the download_gold_plugin.py
script that I am aware of was removed from the build repo in
https://chromium-review.googlesource.com/c/545085/ .

This doesn't remove support for building the plugin because v8 still
uses it I think.

BUG=607968
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2953283002
Cr-Commit-Position: refs/heads/master@{#482031}
Committed: https://chromium.googlesource.com/chromium/src/+/1bb8cb7bc4944ce1687c7d3980bb10f3547fce1c

[Nico, 2017-06-23 18:47:25]

Hooray! But I'm confused by the CL description. Why does v8 use the plugin? Do
they do LTO builds? Have they just haven't merged the chromium change to use lld
for that yet? If they do use the plugin, don't they still have to download it?

[pcc1, 2017-06-23 18:58:07]

On 2017/06/23 18:47:25, Nico wrote:
> Hooray! But I'm confused by the CL description. Why does v8 use the plugin? Do
> they do LTO builds?

I believe so, but only for testing with CFI.

> Have they just haven't merged the chromium change to use lld
> for that yet?

Their LTO support lives in their own gyp build system, so I imagine that it
would require a separate change. See:
https://cs.chromium.org/search/?q=cfi_vptr&type=cs

> If they do use the plugin, don't they still have to download it?

They have their own copy of the download_gold_plugin.py script:
https://cs.chromium.org/chromium/src/v8/gypfiles/download_gold_plugin.py

[Nico, 2017-06-23 19:09:47]

Can we change v8 to do the same thing as chromium, and then remove
everything plugin related?

On Jun 23, 2017 2:58 PM, <pcc@chromium.org> wrote:

> On 2017/06/23 18:47:25, Nico wrote:
> > Hooray! But I'm confused by the CL description. Why does v8 use the
> plugin? Do
> > they do LTO builds?
>
> I believe so, but only for testing with CFI.
>
> > Have they just haven't merged the chromium change to use lld
> > for that yet?
>
> Their LTO support lives in their own gyp build system, so I imagine that it
> would require a separate change. See:
> https://cs.chromium.org/search/?q=cfi_vptr&type=cs
>
> > If they do use the plugin, don't they still have to download it?
>
> They have their own copy of the download_gold_plugin.py script:
> https://cs.chromium.org/chromium/src/v8/gypfiles/download_gold_plugin.py
>
> https://codereview.chromium.org/2953283002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2017-06-23 19:10:16]

But this lgtm.

[pcc1, 2017-06-23 19:41:33]

On 2017/06/23 19:09:47, Nico wrote:
> Can we change v8 to do the same thing as chromium, and then remove
> everything plugin related?

Most likely, yes. I'll open a bug in v8 to track that work.

[pcc1, 2017-06-23 19:41:39]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2017-06-23 19:41:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 21:11:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498246899158670, "parent_rev":
"7a53d835664bc42c6dfbbfe95e2a523343e35fdc", "commit_rev":
"1bb8cb7bc4944ce1687c7d3980bb10f3547fce1c"}

[commit-bot: I haz the power, 2017-06-23 21:12:17]

Description was changed from

==========
Remove support for downloading gold plugin.

Now that https://codereview.chromium.org/2957523002 has landed it
is an error to use the gold plugin (except with ChromeOS, which has
its own copy of the plugin), so we no longer need to be able to
download it. The only other user of the download_gold_plugin.py
script that I am aware of was removed from the build repo in
https://chromium-review.googlesource.com/c/545085/ .

This doesn't remove support for building the plugin because v8 still
uses it I think.

BUG=607968
R=thakis@chromium.org
==========

to

==========
Remove support for downloading gold plugin.

Now that https://codereview.chromium.org/2957523002 has landed it
is an error to use the gold plugin (except with ChromeOS, which has
its own copy of the plugin), so we no longer need to be able to
download it. The only other user of the download_gold_plugin.py
script that I am aware of was removed from the build repo in
https://chromium-review.googlesource.com/c/545085/ .

This doesn't remove support for building the plugin because v8 still
uses it I think.

BUG=607968
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2953283002
Cr-Commit-Position: refs/heads/master@{#482031}
Committed:
https://chromium.googlesource.com/chromium/src/+/1bb8cb7bc4944ce1687c7d3980bb...
==========

[commit-bot: I haz the power, 2017-06-23 21:12:18]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1bb8cb7bc4944ce1687c7d3980bb...

[pcc1, 2017-06-23 21:15:56]

On 2017/06/23 19:41:33, pcc1 wrote:
> On 2017/06/23 19:09:47, Nico wrote:
> > Can we change v8 to do the same thing as chromium, and then remove
> > everything plugin related?
> 
> Most likely, yes. I'll open a bug in v8 to track that work.

https://bugs.chromium.org/p/v8/issues/detail?id=6524