Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: tools/clang/scripts/update.py

Issue 2953283002: Remove support for downloading gold plugin. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/download_gold_plugin.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/scripts/update.py
diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py
index d62e48074c94d592b519072cb7a4fc005028db97..a1273615188246b7c515f24f9a9cd5370a885fdb 100755
--- a/tools/clang/scripts/update.py
+++ b/tools/clang/scripts/update.py
@@ -396,15 +396,9 @@ def VeryifyVersionOfBuiltClangMatchesVERSION():
def UpdateClang(args):
print 'Updating Clang to %s...' % PACKAGE_VERSION
- need_gold_plugin = 'LLVM_DOWNLOAD_GOLD_PLUGIN' in os.environ or (
- sys.platform.startswith('linux') and
- 'buildtype=Official' in os.environ.get('GYP_DEFINES', ''))
-
if ReadStampFile() == PACKAGE_VERSION and not args.force_local_build:
print 'Clang is already up to date.'
- if not need_gold_plugin or os.path.exists(
- os.path.join(LLVM_BUILD_DIR, "lib/LLVMgold.so")):
- return 0
+ return 0
# Reset the stamp file in case the build is unsuccessful.
WriteStampFile('')
@@ -427,11 +421,6 @@ def UpdateClang(args):
print 'clang %s unpacked' % PACKAGE_VERSION
if sys.platform == 'win32':
CopyDiaDllTo(os.path.join(LLVM_BUILD_DIR, 'bin'))
- # Download the gold plugin if requested to by an environment variable.
- # This is used by the CFI ClusterFuzz bot, and it's required for official
- # builds on linux.
- if need_gold_plugin:
- RunCommand(['python', CHROMIUM_DIR+'/build/download_gold_plugin.py'])
WriteStampFile(PACKAGE_VERSION)
return 0
except urllib2.URLError:
« no previous file with comments | « build/download_gold_plugin.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698