Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2953113002: Settings: Network: Always show IP info and fix layout (Closed)

Created:
3 years, 6 months ago by stevenjb
Modified:
3 years, 6 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings: Network: Always show IP info and fix layout This CL fixes the Network section of the network details page to: * Correctly show IP properties even when set to automatic * Fix some minor layout issues BUG=735855 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2953113002 Cr-Commit-Position: refs/heads/master@{#482100} Committed: https://chromium.googlesource.com/chromium/src/+/adefd5760bfb4138b462801d4c695d022b0e442b

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : Feedback #

Messages

Total messages: 11 (6 generated)
stevenjb
3 years, 6 months ago (2017-06-22 19:24:49 UTC) #3
michaelpg
lgtm https://codereview.chromium.org/2953113002/diff/20001/chrome/browser/resources/settings/internet_page/network_ip_config.html File chrome/browser/resources/settings/internet_page/network_ip_config.html (right): https://codereview.chromium.org/2953113002/diff/20001/chrome/browser/resources/settings/internet_page/network_ip_config.html#newcode18 chrome/browser/resources/settings/internet_page/network_ip_config.html:18: hidden$="[[!showIPEditFields_(networkProperties.IPConfigs)]]"> since the function just checks !!foo, would ...
3 years, 6 months ago (2017-06-23 22:33:12 UTC) #4
stevenjb
https://codereview.chromium.org/2953113002/diff/20001/chrome/browser/resources/settings/internet_page/network_ip_config.html File chrome/browser/resources/settings/internet_page/network_ip_config.html (right): https://codereview.chromium.org/2953113002/diff/20001/chrome/browser/resources/settings/internet_page/network_ip_config.html#newcode18 chrome/browser/resources/settings/internet_page/network_ip_config.html:18: hidden$="[[!showIPEditFields_(networkProperties.IPConfigs)]]"> On 2017/06/23 22:33:12, michaelpg wrote: > since the ...
3 years, 6 months ago (2017-06-23 23:27:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953113002/40001
3 years, 6 months ago (2017-06-23 23:28:12 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-24 00:59:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/adefd5760bfb4138b462801d4c69...

Powered by Google App Engine
This is Rietveld 408576698