Settings: Network: Always show IP info and fix layout

Settings: Network: Always show IP info and fix layout

This CL fixes the Network section of the network details page to:
* Correctly show IP properties even when set to automatic
* Fix some minor layout issues

BUG=735855
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2953113002
Cr-Commit-Position: refs/heads/master@{#482100}
Committed: https://chromium.googlesource.com/chromium/src/+/adefd5760bfb4138b462801d4c695d022b0e442b

[stevenjb, 2017-06-22 19:06:00]

Description was changed from

==========
Settings: Network: Always show IP info and fix layout

This CL fixes the Network section of the network details page to:
* Correctly show IP properties even when set to automatic
* Fix some minor layout issues

BUG=735855
==========

to

==========
Settings: Network: Always show IP info and fix layout

This CL fixes the Network section of the network details page to:
* Correctly show IP properties even when set to automatic
* Fix some minor layout issues

BUG=735855
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-06-22 19:24:48]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2017-06-23 22:33:12]

lgtm

https://codereview.chromium.org/2953113002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_ip_config.html
(right):

https://codereview.chromium.org/2953113002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_ip_config.html:18:
hidden$="[[!showIPEditFields_(networkProperties.IPConfigs)]]">
since the function just checks !!foo, would [[!networkProperties.IPConfigs]]
work?
https://www.polymer-project.org/1.0/docs/devguide/data-binding#expressions-in...

[stevenjb, 2017-06-23 23:27:43]

https://codereview.chromium.org/2953113002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_ip_config.html
(right):

https://codereview.chromium.org/2953113002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_ip_config.html:18:
hidden$="[[!showIPEditFields_(networkProperties.IPConfigs)]]">
On 2017/06/23 22:33:12, michaelpg wrote:
> since the function just checks !!foo, would [[!networkProperties.IPConfigs]]
> work?
>
https://www.polymer-project.org/1.0/docs/devguide/data-binding#expressions-in...

Good point. Done.

[stevenjb, 2017-06-23 23:27:47]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-06-23 23:27:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2953113002/#ps40001
(title: "Feedback")

[commit-bot: I haz the power, 2017-06-23 23:28:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-24 00:58:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498260467170850,
"parent_rev": "867f5de0dfe3bda722222177ad53c17f91568a4b", "commit_rev":
"adefd5760bfb4138b462801d4c695d022b0e442b"}

[commit-bot: I haz the power, 2017-06-24 00:59:09]

Description was changed from

==========
Settings: Network: Always show IP info and fix layout

This CL fixes the Network section of the network details page to:
* Correctly show IP properties even when set to automatic
* Fix some minor layout issues

BUG=735855
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings: Network: Always show IP info and fix layout

This CL fixes the Network section of the network details page to:
* Correctly show IP properties even when set to automatic
* Fix some minor layout issues

BUG=735855
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2953113002
Cr-Commit-Position: refs/heads/master@{#482100}
Committed:
https://chromium.googlesource.com/chromium/src/+/adefd5760bfb4138b462801d4c69...
==========

[commit-bot: I haz the power, 2017-06-24 00:59:10]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/adefd5760bfb4138b462801d4c69...