chrome/browser/resources/settings/internet_page/network_ip_config.js - Issue 2953113002: Settings: Network: Always show IP info and fix layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/network_ip_config.js

Issue 2953113002: Settings: Network: Always show IP info and fix layout (Closed)

Patch Set: Feedback Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/network_ip_config.html ('k') | chrome/browser/resources/settings/internet_page/network_nameservers.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/network_ip_config.js

diff --git a/chrome/browser/resources/settings/internet_page/network_ip_config.js b/chrome/browser/resources/settings/internet_page/network_ip_config.js

index da9aefaf24d626e3ca3f0add32de31af9b3450f8..d84e8ea49645f6347cb70c246741bd5c06f7a227 100644

--- a/chrome/browser/resources/settings/internet_page/network_ip_config.js

+++ b/chrome/browser/resources/settings/internet_page/network_ip_config.js

@@ -161,14 +161,6 @@ Polymer({

return result;

- /**

- * @return {boolean}

- * @private

- */

- showIPEditFields_: function() {

- return this.editable && !this.automatic_;

- },

/**

* @return {Object} An object with the edit type for each editable field.

* @private