LatencyInfo trace_id_ no longer dependent on sequence_number.

LatencyInfo trace_id_ no longer dependent on sequence_number.

trace_id_ is the primary consumer of sequence_numbers 
in LatencyInfo.

In order to get rid of sequence_number, first remove the 
dependency between trace_id_ and sequence_number.

This is a precursor to 
https://codereview.chromium.org/2914023002.

BUG=731202
TEST=RenderWidgetHostLatencyTrackerTest, latency_unittests
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2953073002
Cr-Commit-Position: refs/heads/master@{#482718}
Committed: https://chromium.googlesource.com/chromium/src/+/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a

[tdresser, 2017-06-22 15:45:12]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 15:45:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 17:33:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 17:33:15]

Dry run: This issue passed the CQ dry run.

[tdresser, 2017-06-22 18:38:48]

Description was changed from

==========
Not for review. Ensuring RWHLT OnInputEvent only called from Browser::UI

BUG=
==========

to

==========
Not for review. Ensuring RWHLT OnInputEvent only called from Browser::UI

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[tdresser, 2017-06-22 18:40:40]

Description was changed from

==========
Not for review. Ensuring RWHLT OnInputEvent only called from Browser::UI

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
LatencyInfo trace_id_ no longer dependent on sequence_number.

trace_id_ is the primary consumer of sequence_numbers 
in LatencyInfo.

In order to get rid of sequence_number, first remove the 
dependency between trace_id_ and sequence_number.

This is a precursor to 
https://codereview.chromium.org/2914023002.

BUG=731202
TEST=RenderWidgetHostLatencyTrackerTest, latency_unittests
==========

[tdresser, 2017-06-22 18:40:58]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 18:41:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 19:42:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 19:42:59]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tdresser, 2017-06-22 20:02:05]

Description was changed from

==========
LatencyInfo trace_id_ no longer dependent on sequence_number.

trace_id_ is the primary consumer of sequence_numbers 
in LatencyInfo.

In order to get rid of sequence_number, first remove the 
dependency between trace_id_ and sequence_number.

This is a precursor to 
https://codereview.chromium.org/2914023002.

BUG=731202
TEST=RenderWidgetHostLatencyTrackerTest, latency_unittests
==========

to

==========
LatencyInfo trace_id_ no longer dependent on sequence_number.

trace_id_ is the primary consumer of sequence_numbers 
in LatencyInfo.

In order to get rid of sequence_number, first remove the 
dependency between trace_id_ and sequence_number.

This is a precursor to 
https://codereview.chromium.org/2914023002.

BUG=731202
TEST=RenderWidgetHostLatencyTrackerTest, latency_unittests
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[tdresser, 2017-06-22 20:02:12]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 20:02:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 22:26:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 22:26:38]

Dry run: This issue passed the CQ dry run.

[tdresser, 2017-06-23 12:05:47]

tdresser@chromium.org changed reviewers:
+ dtapuska@chromium.org

[tdresser, 2017-06-23 12:05:47]

+dtapuska for initial review.

[dtapuska, 2017-06-26 20:46:50]

On 2017/06/23 12:05:47, tdresser wrote:
> +dtapuska for initial review.

lgtm

[tdresser, 2017-06-26 20:50:58]

tdresser@chromium.org changed reviewers:
+ brianderson@chromium.org, kenrb@chromium.org

[tdresser, 2017-06-26 20:50:58]

+kenrb@ for ipc/mojo.
+brianderson@ for cc.

[kenrb, 2017-06-26 20:53:11]

ipc/mojo lgtm

[brianderson, 2017-06-27 18:00:59]

lgtm

https://codereview.chromium.org/2953073002/diff/40001/cc/trees/latency_info_s...
File cc/trees/latency_info_swap_promise_monitor.cc (right):

https://codereview.chromium.org/2953073002/diff/40001/cc/trees/latency_info_s...
cc/trees/latency_info_swap_promise_monitor.cc:95:
ui::INPUT_EVENT_LATENCY_FORWARD_SCROLL_UPDATE_TO_MAIN_COMPONENT);
The new order here seems more intuitive, but how did it work before?

https://codereview.chromium.org/2953073002/diff/40001/content/browser/rendere...
File
content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
(right):

https://codereview.chromium.org/2953073002/diff/40001/content/browser/rendere...
content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc:816:
fake_latency.set_trace_id(5);
Would it make sense to have 5 be a const variable somewhere with a comment
indicating why 5 is used?

[tdresser, 2017-06-27 18:33:12]

https://codereview.chromium.org/2953073002/diff/40001/cc/trees/latency_info_s...
File cc/trees/latency_info_swap_promise_monitor.cc (right):

https://codereview.chromium.org/2953073002/diff/40001/cc/trees/latency_info_s...
cc/trees/latency_info_swap_promise_monitor.cc:95:
ui::INPUT_EVENT_LATENCY_FORWARD_SCROLL_UPDATE_TO_MAIN_COMPONENT);
On 2017/06/27 18:00:58, brianderson wrote:
> The new order here seems more intuitive, but how did it work before?

Both CopyLatencyFrom and AddLatencyNumberWithTraceName just add components. An
earlier version of this required this reorder, at this point it's just cosmetic.

https://codereview.chromium.org/2953073002/diff/40001/content/browser/rendere...
File
content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
(right):

https://codereview.chromium.org/2953073002/diff/40001/content/browser/rendere...
content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc:816:
fake_latency.set_trace_id(5);
On 2017/06/27 18:00:58, brianderson wrote:
> Would it make sense to have 5 be a const variable somewhere with a comment
> indicating why 5 is used?

Done.

[tdresser, 2017-06-27 18:33:15]

The CQ bit was checked by tdresser@chromium.org

[tdresser, 2017-06-27 18:33:16]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org,
dtapuska@chromium.org, brianderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2953073002/#ps60001
(title: "Address nit.")

[commit-bot: I haz the power, 2017-06-27 18:33:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 19:56:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498588395863510,
"parent_rev": "62cdea2d511f19967ffb31be31f078350fade283", "commit_rev":
"0b9ca7b05e10426b8b2d0fce22306ca4e120a821"}

[commit-bot: I haz the power, 2017-06-27 19:56:47]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498588395863510,
"parent_rev": "cdebfd33f1272331c405bf8f66016d1c9f0f87b4", "commit_rev":
"7a5ff008cb7963c34c5207fa60145a1d7d9ea99a"}

[commit-bot: I haz the power, 2017-06-27 19:57:02]

Description was changed from

==========
LatencyInfo trace_id_ no longer dependent on sequence_number.

trace_id_ is the primary consumer of sequence_numbers 
in LatencyInfo.

In order to get rid of sequence_number, first remove the 
dependency between trace_id_ and sequence_number.

This is a precursor to 
https://codereview.chromium.org/2914023002.

BUG=731202
TEST=RenderWidgetHostLatencyTrackerTest, latency_unittests
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
LatencyInfo trace_id_ no longer dependent on sequence_number.

trace_id_ is the primary consumer of sequence_numbers 
in LatencyInfo.

In order to get rid of sequence_number, first remove the 
dependency between trace_id_ and sequence_number.

This is a precursor to 
https://codereview.chromium.org/2914023002.

BUG=731202
TEST=RenderWidgetHostLatencyTrackerTest, latency_unittests
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2953073002
Cr-Commit-Position: refs/heads/master@{#482718}
Committed:
https://chromium.googlesource.com/chromium/src/+/7a5ff008cb7963c34c5207fa6014...
==========

[commit-bot: I haz the power, 2017-06-27 19:57:03]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7a5ff008cb7963c34c5207fa6014...