LatencyInfo trace_id_ no longer dependent on sequence_number.

content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/input/render_widget_host_latency_tracker.h"
 #include "base/metrics/metrics_hashes.h"
 #include "base/test/histogram_tester.h"
 #include "components/metrics/proto/ukm/entry.pb.h"
 #include "components/rappor/public/rappor_utils.h"
 #include "components/rappor/test_rappor_service.h"
@@ skipping 795 matching lines @@
     SyntheticWebTouchEvent event;
     {
       // Touch start.
       event.PressPoint(1, 1);
 
       ui::LatencyInfo latency;
       latency.set_source_event_type(ui::SourceEventType::TOUCH);
       tracker()->OnInputEvent(event, &latency);
 
       ui::LatencyInfo fake_latency;
+      fake_latency.set_trace_id(5);

[brianderson, 2017/06/27 18:00:58]

Would it make sense to have 5 be a const variable somewhere with a comment
indicating why 5 is used?

[tdresser, 2017/06/27 18:33:12]

Done.

       fake_latency.set_source_event_type(ui::SourceEventType::TOUCH);
       fake_latency.AddLatencyNumberWithTimestamp(
           ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
           tracker()->latency_component_id(), 0,
           base::TimeTicks() +
               base::TimeDelta::FromMilliseconds(touchstart_timestamps_ms[0]),
           1);
 
       fake_latency.AddLatencyNumberWithTimestamp(
           ui::INPUT_EVENT_LATENCY_RENDERER_MAIN_COMPONENT, 0, 0,
@@ skipping 26 matching lines @@
 
       EXPECT_TRUE(latency.FindLatency(
           ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0, nullptr));
       EXPECT_TRUE(
           latency.FindLatency(ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
                                    tracker()->latency_component_id(), nullptr));
 
       EXPECT_EQ(2U, latency.latency_components().size());
 
       ui::LatencyInfo fake_latency;
+      fake_latency.set_trace_id(5);
       fake_latency.set_source_event_type(ui::SourceEventType::TOUCH);
       fake_latency.AddLatencyNumberWithTimestamp(
           ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
           tracker()->latency_component_id(), 0,
           base::TimeTicks() +
               base::TimeDelta::FromMilliseconds(touchmove_timestamps_ms[0]),
           1);
 
       fake_latency.AddLatencyNumberWithTimestamp(
           ui::INPUT_EVENT_LATENCY_RENDERER_MAIN_COMPONENT, 0, 0,
@@ skipping 23 matching lines @@
 
       EXPECT_TRUE(latency.FindLatency(
           ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0, nullptr));
       EXPECT_TRUE(
           latency.FindLatency(ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
                                    tracker()->latency_component_id(), nullptr));
 
       EXPECT_EQ(2U, latency.latency_components().size());
 
       ui::LatencyInfo fake_latency;
+      fake_latency.set_trace_id(5);
       fake_latency.set_source_event_type(ui::SourceEventType::TOUCH);
       fake_latency.AddLatencyNumberWithTimestamp(
           ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
           tracker()->latency_component_id(), 0,
           base::TimeTicks() +
               base::TimeDelta::FromMilliseconds(touchend_timestamps_ms[0]),
           1);
 
       fake_latency.AddLatencyNumberWithTimestamp(
           ui::INPUT_EVENT_LATENCY_RENDERER_MAIN_COMPONENT, 0, 0,
@@ skipping 82 matching lines @@
        {INPUT_EVENT_ACK_STATE_NOT_CONSUMED, INPUT_EVENT_ACK_STATE_CONSUMED}) {
     {
       NativeWebKeyboardEvent event(blink::WebKeyboardEvent::kRawKeyDown,
                                    blink::WebInputEvent::kNoModifiers,
                                    base::TimeTicks::Now());
       ui::LatencyInfo latency_info;
       latency_info.set_source_event_type(ui::SourceEventType::KEY_PRESS);
       tracker()->OnInputEvent(event, &latency_info);
 
       ui::LatencyInfo fake_latency;
+      fake_latency.set_trace_id(5);
       fake_latency.set_source_event_type(ui::SourceEventType::KEY_PRESS);
       fake_latency.AddLatencyNumberWithTimestamp(
           ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
           tracker()->latency_component_id(), 0,
           base::TimeTicks() +
               base::TimeDelta::FromMilliseconds(event_timestamps_ms[0]),
           1);
 
       fake_latency.AddLatencyNumberWithTimestamp(
           ui::INPUT_EVENT_LATENCY_RENDERER_MAIN_COMPONENT, 0, 0,
@@ skipping 36 matching lines @@
 }
 
 TEST_F(RenderWidgetHostLatencyTrackerTest, KeyUILatency) {
   // These numbers are sensitive to where the histogram buckets are.
   int event_timestamps_microseconds[] = {100, 185};
 
   NativeWebKeyboardEvent event(blink::WebKeyboardEvent::kChar,
                                blink::WebInputEvent::kNoModifiers,
                                base::TimeTicks::Now());
   ui::LatencyInfo latency_info;
+  latency_info.set_trace_id(5);
   latency_info.set_source_event_type(ui::SourceEventType::KEY_PRESS);
   latency_info.AddLatencyNumberWithTimestamp(
       ui::INPUT_EVENT_LATENCY_UI_COMPONENT, 0, 0,
       base::TimeTicks() +
           base::TimeDelta::FromMicroseconds(event_timestamps_microseconds[0]),
       1);
 
   latency_info.AddLatencyNumberWithTimestamp(
       ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
       tracker()->latency_component_id(), 0,
@@ skipping 12 matching lines @@
 }
 
 TEST_F(RenderWidgetHostLatencyTrackerTest, KeyAckedLatency) {
   // These numbers are sensitive to where the histogram buckets are.
   int event_timestamps_microseconds[] = {11, 24};
 
   NativeWebKeyboardEvent event(blink::WebKeyboardEvent::kRawKeyDown,
                                blink::WebInputEvent::kNoModifiers,
                                base::TimeTicks::Now());
   ui::LatencyInfo latency_info;
+  latency_info.set_trace_id(5);
   latency_info.set_source_event_type(ui::SourceEventType::KEY_PRESS);
 
   latency_info.AddLatencyNumberWithTimestamp(
       ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
       tracker()->latency_component_id(), 0,
       base::TimeTicks() +
           base::TimeDelta::FromMicroseconds(event_timestamps_microseconds[0]),
       1);
 
   latency_info.AddLatencyNumberWithTimestamp(
@@ skipping 14 matching lines @@
       ElementsAre(Bucket(
           event_timestamps_microseconds[1] - event_timestamps_microseconds[0],
           1)));
 }
 
 TEST_F(RenderWidgetHostLatencyTrackerTest, KeyEndToEndLatency) {
   // These numbers are sensitive to where the histogram buckets are.
   int event_timestamps_microseconds[] = {11, 24};
 
   ui::LatencyInfo latency_info;
+  latency_info.set_trace_id(5);
   latency_info.set_source_event_type(ui::SourceEventType::KEY_PRESS);
   latency_info.AddLatencyNumberWithTimestamp(
       ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0, 0,
       base::TimeTicks() +
           base::TimeDelta::FromMicroseconds(event_timestamps_microseconds[0]),
       1);
 
   latency_info.AddLatencyNumberWithTimestamp(
       ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
       tracker()->latency_component_id(), 0,
@@ skipping 39 matching lines @@
 
   {
     // Additional touch start will be ignored for queueing and blocking time
     // metrics.
     int touchstart_timestamps_ms[] = {11, 25, 35};
     ui::LatencyInfo latency;
     event.PressPoint(1, 1);
     tracker()->OnInputEvent(event, &latency);
 
     ui::LatencyInfo fake_latency;
+    fake_latency.set_trace_id(5);
     fake_latency.AddLatencyNumberWithTimestamp(
         ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
         tracker()->latency_component_id(), 0,
         base::TimeTicks() +
             base::TimeDelta::FromMilliseconds(touchstart_timestamps_ms[0]),
         1);
 
     fake_latency.AddLatencyNumberWithTimestamp(
         ui::INPUT_EVENT_LATENCY_RENDERER_MAIN_COMPONENT, 0, 0,
         base::TimeTicks() +
@@ skipping 49 matching lines @@
     // Wheel event.
     ui::LatencyInfo latency;
     latency.set_source_event_type(ui::SourceEventType::WHEEL);
     // These numbers are sensitive to where the histogram buckets are.
     int timestamps_ms[] = {11, 25, 35};
     auto wheel_event = SyntheticWebMouseWheelEventBuilder::Build(
         blink::WebMouseWheelEvent::kPhaseChanged);
     tracker()->OnInputEvent(touch_event, &latency);
 
     ui::LatencyInfo fake_latency;
+    fake_latency.set_trace_id(5);
     fake_latency.set_source_event_type(ui::SourceEventType::TOUCH);
     fake_latency.AddLatencyNumberWithTimestamp(
         ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
         tracker()->latency_component_id(), 0,
         base::TimeTicks() + base::TimeDelta::FromMilliseconds(timestamps_ms[0]),
         1);
 
     fake_latency.AddLatencyNumberWithTimestamp(
         ui::INPUT_EVENT_LATENCY_RENDERER_MAIN_COMPONENT, 0, 0,
         base::TimeTicks() + base::TimeDelta::FromMilliseconds(timestamps_ms[1]),
@@ skipping 12 matching lines @@
 
     tracker()->OnInputEventAck(wheel_event, &latency, ack_state);
   }
 
   EXPECT_THAT(histogram_tester().GetAllSamples(
                   "Event.Latency.QueueingTime.MouseWheelDefaultAllowed"),
               ElementsAre(Bucket(14, 1)));
 }
 
 }  // namespace content