third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp - Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp b/third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp

index f172052ba94889c044bab4e7b44d92cfc2fa7e6f..5d5ebb66b0a7a042a375f1559a46845ed08254e7 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp

+++ b/third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp

@@ -26,8 +26,7 @@ bool ShouldCheckNode(const Node& node) {

if (!node.IsElementNode())

return false;

// TODO(editing-dev): Make |Position| constructors take const parameters.

- const Position& position =

- Position::FirstPositionInNode(const_cast<Node*>(&node));

+ const Position& position = Position::FirstPositionInNode(node);

if (!IsEditablePosition(position))

return false;

return SpellChecker::IsSpellCheckingEnabledAt(position);