third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp - Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp b/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp

index 3531094f7c75377c7090e51d75f8c14a9168c7c1..d1d5a15c0d4a042f6acd8481ee75575f3c198420 100644

--- a/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp

@@ -283,10 +283,11 @@ TEST_F(StyledMarkupSerializerTest, AcrossInvisibleElements) {

SetBodyContent(body_content);

Element* span1 = GetDocument().getElementById("span1");

Element* span2 = GetDocument().getElementById("span2");

- Position start_dom = Position::FirstPositionInNode(span1);

+ Position start_dom = Position::FirstPositionInNode(*span1);

Position end_dom = Position::LastPositionInNode(span2);

EXPECT_EQ("", SerializePart<EditingStrategy>(start_dom, end_dom));

- PositionInFlatTree start_ict = PositionInFlatTree::FirstPositionInNode(span1);

+ PositionInFlatTree start_ict =

+ PositionInFlatTree::FirstPositionInNode(*span1);

PositionInFlatTree end_ict = PositionInFlatTree::LastPositionInNode(span2);

EXPECT_EQ("", SerializePart<EditingInFlatTreeStrategy>(start_ict, end_ict));

}