Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
index 4dda54c77b692b36d6c73c3b3d308ebd3223f48b..51037726195807c88f997690ea925479267dc92b 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
@@ -212,7 +212,7 @@ void SpellChecker::DidBeginEditing(Element* element) {
TextControlElement* enclosing_text_control_element = nullptr;
if (!IsTextControlElement(*element)) {
enclosing_text_control_element =
- EnclosingTextControl(Position::FirstPositionInNode(element));
+ EnclosingTextControl(Position::FirstPositionInNode(*element));
}
element =
enclosing_text_control_element ? enclosing_text_control_element : element;
@@ -537,7 +537,7 @@ void SpellChecker::MarkMisspellingsAfterReplaceSelectionCommand(
if (!node)
return;
- EphemeralRange paragraph_range(Position::FirstPositionInNode(node),
+ EphemeralRange paragraph_range(Position::FirstPositionInNode(*node),
Position::LastPositionInNode(node));
TextCheckingParagraph text_to_check(inserted_range, paragraph_range);
ChunkAndMarkAllMisspellings(text_to_check);
« no previous file with comments | « third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698