Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
index f7b379316e968c001b30470d3f337ff63778af60..e44d9d4fae83b50789b5c167af7cf7b97b8a819c 100644
--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
@@ -592,7 +592,7 @@ void ReplaceSelectionCommand::RemoveRedundantStylesAndKeepStyleSpanInline(
!context
? ToHTMLQuoteElement(context)
: ToHTMLQuoteElement(EnclosingNodeOfType(
- Position::FirstPositionInNode(context),
+ Position::FirstPositionInNode(*context),
IsMailHTMLBlockquoteElement, kCanCrossEditingBoundary));
// EditingStyle::removeStyleFromRulesAndContext() uses StyleResolver,
@@ -1254,7 +1254,7 @@ void ReplaceSelectionCommand::DoApply(EditingState* editing_state) {
SplitTextNode(ToText(insertion_pos.ComputeContainerNode()),
insertion_pos.OffsetInContainerNode());
insertion_pos =
- Position::FirstPositionInNode(insertion_pos.ComputeContainerNode());
+ Position::FirstPositionInNode(*insertion_pos.ComputeContainerNode());
}
if (HTMLElement* element_to_split_to =
@@ -1543,7 +1543,7 @@ void ReplaceSelectionCommand::DoApply(EditingState* editing_state) {
return;
SetEndingSelection(
SelectionInDOMTree::Builder()
- .Collapse(Position::FirstPositionInNode(new_list_item))
+ .Collapse(Position::FirstPositionInNode(*new_list_item))
.Build());
} else {
// Use a default paragraph element (a plain div) for the empty
@@ -1714,7 +1714,7 @@ void ReplaceSelectionCommand::AddSpacesForSmartReplace(
InsertNodeBefore(node, start_node, editing_state);
if (editing_state->IsAborted())
return;
- start_of_inserted_content_ = Position::FirstPositionInNode(node);
+ start_of_inserted_content_ = Position::FirstPositionInNode(*node);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698