Make Position::FirstPositionInNode() to take const Node& instead of Node*

third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2009, 2010, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 574 matching lines @@
       ContainerNode* context = element->parentNode();
 
       // If Mail wraps the fragment with a Paste as Quotation blockquote, or if
       // you're pasting into a quoted region, styles from blockquoteNode are
       // allowed to override those from the source document, see
       // <rdar://problem/4930986> and <rdar://problem/5089327>.
       HTMLQuoteElement* blockquote_element =
           !context
               ? ToHTMLQuoteElement(context)
               : ToHTMLQuoteElement(EnclosingNodeOfType(
-                    Position::FirstPositionInNode(context),
+                    Position::FirstPositionInNode(*context),
                     IsMailHTMLBlockquoteElement, kCanCrossEditingBoundary));
 
       // EditingStyle::removeStyleFromRulesAndContext() uses StyleResolver,
       // which requires clean style.
       // TODO(editing-dev): There is currently no way to update style without
       // updating layout. We might want to have updateLifcycleToStyleClean()
       // similar to FrameView::updateLifecylceToLayoutClean() in Document.
       GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();
 
       if (blockquote_element)
@@ skipping 641 matching lines @@
   // We can skip this optimization for fragments not wrapped in one of
   // our style spans and for positions inside list items
   // since insertAsListItems already does the right thing.
   if (!match_style_ && !EnclosingList(insertion_pos.ComputeContainerNode())) {
     if (insertion_pos.ComputeContainerNode()->IsTextNode() &&
         insertion_pos.OffsetInContainerNode() &&
         !insertion_pos.AtLastEditingPositionForNode()) {
       SplitTextNode(ToText(insertion_pos.ComputeContainerNode()),
                     insertion_pos.OffsetInContainerNode());
       insertion_pos =
-          Position::FirstPositionInNode(insertion_pos.ComputeContainerNode());
+          Position::FirstPositionInNode(*insertion_pos.ComputeContainerNode());
     }
 
     if (HTMLElement* element_to_split_to =
             ElementToSplitToAvoidPastingIntoInlineElementsWithStyle(
                 insertion_pos)) {
       if (insertion_pos.ComputeContainerNode() !=
           element_to_split_to->parentNode()) {
         Node* split_start = insertion_pos.ComputeNodeAfterPosition();
         if (!split_start)
           split_start = insertion_pos.ComputeContainerNode();
@@ skipping 268 matching lines @@
         Element* enclosing_block_element = EnclosingBlock(
             end_of_inserted_content.DeepEquivalent().AnchorNode());
         if (IsListItem(enclosing_block_element)) {
           HTMLLIElement* new_list_item = HTMLLIElement::Create(GetDocument());
           InsertNodeAfter(new_list_item, enclosing_block_element,
                           editing_state);
           if (editing_state->IsAborted())
             return;
           SetEndingSelection(
               SelectionInDOMTree::Builder()
-                  .Collapse(Position::FirstPositionInNode(new_list_item))
+                  .Collapse(Position::FirstPositionInNode(*new_list_item))
                   .Build());
         } else {
           // Use a default paragraph element (a plain div) for the empty
           // paragraph, using the last paragraph block's style seems to annoy
           // users.
           InsertParagraphSeparator(
               editing_state, true,
               !start_is_inside_mail_blockquote &&
                   HighestEnclosingNodeOfType(
                       end_of_inserted_content.DeepEquivalent(),
@@ skipping 150 matching lines @@
             start_node, end_of_inserted_content_.OffsetInContainerNode() + 1);
     } else {
       Text* node = GetDocument().CreateEditingTextNode(
           collapse_white_space ? NonBreakingSpaceString() : " ");
       // Don't updateNodesInserted. Doing so would set m_endOfInsertedContent to
       // be the node containing the leading space, but m_endOfInsertedContent is
       // supposed to mark the end of pasted content.
       InsertNodeBefore(node, start_node, editing_state);
       if (editing_state->IsAborted())
         return;
-      start_of_inserted_content_ = Position::FirstPositionInNode(node);
+      start_of_inserted_content_ = Position::FirstPositionInNode(*node);
     }
   }
 }
 
 void ReplaceSelectionCommand::CompleteHTMLReplacement(
     const Position& last_position_to_select,
     EditingState* editing_state) {
   Position start = PositionAtStartOfInsertedContent().DeepEquivalent();
   Position end = PositionAtEndOfInsertedContent().DeepEquivalent();
 
@@ skipping 281 matching lines @@
   visitor->Trace(start_of_inserted_content_);
   visitor->Trace(end_of_inserted_content_);
   visitor->Trace(insertion_style_);
   visitor->Trace(document_fragment_);
   visitor->Trace(start_of_inserted_range_);
   visitor->Trace(end_of_inserted_range_);
   CompositeEditCommand::Trace(visitor);
 }
 
 }  // namespace blink