third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp - Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

index 0d7f811e1c06cc697bf79ab890429bd28dbc2533..cdafbfa884f6417baf442ef0ae6269eea0047976 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

@@ -58,7 +58,7 @@ Position InsertTextCommand::PositionInsideTextNode(

InsertNodeAtTabSpanPosition(text_node, pos, editing_state);

if (editing_state->IsAborted())

return Position();

- return Position::FirstPositionInNode(text_node);

+ return Position::FirstPositionInNode(*text_node);

}

// Prepare for text input by looking at the specified position.

@@ -68,7 +68,7 @@ Position InsertTextCommand::PositionInsideTextNode(

InsertNodeAt(text_node, pos, editing_state);

if (editing_state->IsAborted())

return Position();

- return Position::FirstPositionInNode(text_node);

+ return Position::FirstPositionInNode(*text_node);

}

return pos;