third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp - Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

index 7e2d71e0bb139fb119ba0f0817e59ded6200335c..760d55c9a1525f7a6e596380edb777445959d1cb 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

@@ -337,7 +337,7 @@ void InsertParagraphSeparatorCommand::DoApply(EditingState* editing_state) {

return;

SetEndingSelection(SelectionInDOMTree::Builder()

- .Collapse(Position::FirstPositionInNode(parent))

+ .Collapse(Position::FirstPositionInNode(*parent))

.SetIsDirectional(EndingSelection().IsDirectional())

.Build());

return;

@@ -496,7 +496,7 @@ void InsertParagraphSeparatorCommand::DoApply(EditingState* editing_state) {

SplitTextNode(text_node, text_offset);

GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();

- position_after_split = Position::FirstPositionInNode(text_node);

+ position_after_split = Position::FirstPositionInNode(*text_node);

insertion_position = Position(text_node->previousSibling(), text_offset);

}

@@ -590,7 +590,7 @@ void InsertParagraphSeparatorCommand::DoApply(EditingState* editing_state) {

SetEndingSelection(

SelectionInDOMTree::Builder()

- .Collapse(Position::FirstPositionInNode(block_to_insert))

+ .Collapse(Position::FirstPositionInNode(*block_to_insert))

.SetIsDirectional(EndingSelection().IsDirectional())

.Build());

ApplyStyleAfterInsertion(start_block, editing_state);