third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp - Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp b/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp

index 2bb61c87c8a994dcd7bf7b0518870d63ba36564b..37ed8d25ee5d1f397cc8135c01bb9596a872960d 100644

--- a/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp

@@ -359,7 +359,7 @@ static PositionWithAffinityTemplate<Strategy> LogicalStartOfLineAlgorithm(

if (!editable_root->contains(

vis_pos.GetPosition().ComputeContainerNode())) {

return PositionWithAffinityTemplate<Strategy>(

- PositionTemplate<Strategy>::FirstPositionInNode(editable_root));

+ PositionTemplate<Strategy>::FirstPositionInNode(*editable_root));

}