Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp b/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
index a5c92fe5bb8f5123a957864a125f70af3039dd3a..741a73e8d55d24d9e5dfd4d7bbc0356e6303b0a5 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
@@ -246,11 +246,11 @@ TEST_F(VisibleUnitsTest, canonicalPositionOfWithInputElement) {
EXPECT_EQ(Position::BeforeNode(*input),
CanonicalPositionOf(Position::FirstPositionInNode(
- GetDocument().documentElement())));
+ *GetDocument().documentElement())));
EXPECT_EQ(PositionInFlatTree::BeforeNode(*input),
CanonicalPositionOf(PositionInFlatTree::FirstPositionInNode(
- GetDocument().documentElement())));
+ *GetDocument().documentElement())));
}
TEST_F(VisibleUnitsTest, characterBefore) {
@@ -1338,13 +1338,13 @@ TEST_F(VisibleUnitsTest, mostForwardCaretPositionFirstLetter) {
EXPECT_EQ(Position(GetDocument().body(), 0),
MostForwardCaretPosition(
- Position::FirstPositionInNode(GetDocument().body())));
+ Position::FirstPositionInNode(*GetDocument().body())));
EXPECT_EQ(
Position(sample, 1),
MostForwardCaretPosition(Position::BeforeNode(*sample->parentNode())));
EXPECT_EQ(Position(sample, 1),
MostForwardCaretPosition(
- Position::FirstPositionInNode(sample->parentNode())));
+ Position::FirstPositionInNode(*sample->parentNode())));
EXPECT_EQ(Position(sample, 1), MostForwardCaretPosition(Position(sample, 0)));
EXPECT_EQ(Position(sample, 1), MostForwardCaretPosition(Position(sample, 1)));
EXPECT_EQ(Position(sample, 2), MostForwardCaretPosition(Position(sample, 2)));

Powered by Google App Engine
This is Rietveld 408576698