Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
index 8c81961df3e70d225ecf13c5623bcf547f9503d2..868deaadf37992cf1a6fd3ded0c31678678f3ad0 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
@@ -418,7 +418,7 @@ static PositionTemplate<Strategy> NextBoundaryAlgorithm(
BackwardsTextBuffer prefix_string;
if (RequiresContextForWordBoundary(CharacterAfter(c))) {
SimplifiedBackwardsTextIteratorAlgorithm<Strategy> backwards_iterator(
- PositionTemplate<Strategy>::FirstPositionInNode(&d), start);
+ PositionTemplate<Strategy>::FirstPositionInNode(d), start);
while (!backwards_iterator.AtEnd()) {
backwards_iterator.CopyTextTo(&prefix_string);
int context_start_index = StartOfLastWordBoundaryContext(
@@ -590,7 +590,7 @@ static VisiblePositionTemplate<Strategy> StartOfDocumentAlgorithm(
return VisiblePositionTemplate<Strategy>();
return CreateVisiblePosition(PositionTemplate<Strategy>::FirstPositionInNode(
- node->GetDocument().documentElement()));
+ *node->GetDocument().documentElement()));
}
VisiblePosition StartOfDocument(const VisiblePosition& c) {

Powered by Google App Engine
This is Rietveld 408576698