Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
index 868b1b216f12043ce375203e55b1c51a6eb66773..1fa4edd23512f4ed478fa97cfb9972a7b7f014de 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
@@ -253,7 +253,7 @@ TEST_F(VisibleSelectionTest, SelectAllWithInputElement) {
const VisibleSelection& visible_selectin_in_dom_tree = CreateVisibleSelection(
SelectionInDOMTree::Builder()
- .Collapse(Position::FirstPositionInNode(html_element))
+ .Collapse(Position::FirstPositionInNode(*html_element))
.Extend(Position::LastPositionInNode(html_element))
.Build());
EXPECT_EQ(SelectionInDOMTree::Builder()
@@ -265,7 +265,7 @@ TEST_F(VisibleSelectionTest, SelectAllWithInputElement) {
const VisibleSelectionInFlatTree& visible_selectin_in_flat_tree =
CreateVisibleSelection(
SelectionInFlatTree::Builder()
- .Collapse(PositionInFlatTree::FirstPositionInNode(html_element))
+ .Collapse(PositionInFlatTree::FirstPositionInNode(*html_element))
.Extend(PositionInFlatTree::LastPositionInNode(html_element))
.Build());
EXPECT_EQ(SelectionInFlatTree::Builder()
@@ -292,12 +292,12 @@ TEST_F(VisibleSelectionTest, ShadowCrossing) {
VisibleSelection selection = CreateVisibleSelection(
SelectionInDOMTree::Builder()
- .Collapse(Position::FirstPositionInNode(one))
+ .Collapse(Position::FirstPositionInNode(*one))
.Extend(Position::LastPositionInNode(shadow_root))
.Build());
VisibleSelectionInFlatTree selection_in_flat_tree = CreateVisibleSelection(
SelectionInFlatTree::Builder()
- .Collapse(PositionInFlatTree::FirstPositionInNode(one))
+ .Collapse(PositionInFlatTree::FirstPositionInNode(*one))
.Extend(PositionInFlatTree::LastPositionInNode(host))
.Build());
@@ -327,12 +327,12 @@ TEST_F(VisibleSelectionTest, ShadowV0DistributedNodes) {
VisibleSelection selection =
CreateVisibleSelection(SelectionInDOMTree::Builder()
- .Collapse(Position::FirstPositionInNode(one))
+ .Collapse(Position::FirstPositionInNode(*one))
.Extend(Position::LastPositionInNode(two))
.Build());
VisibleSelectionInFlatTree selection_in_flat_tree = CreateVisibleSelection(
SelectionInFlatTree::Builder()
- .Collapse(PositionInFlatTree::FirstPositionInNode(one))
+ .Collapse(PositionInFlatTree::FirstPositionInNode(*one))
.Extend(PositionInFlatTree::LastPositionInNode(two))
.Build());
@@ -373,12 +373,12 @@ TEST_F(VisibleSelectionTest, ShadowNested) {
VisibleSelection selection = CreateVisibleSelection(
SelectionInDOMTree::Builder()
- .Collapse(Position::FirstPositionInNode(one))
+ .Collapse(Position::FirstPositionInNode(*one))
.Extend(Position::LastPositionInNode(shadow_root2))
.Build());
VisibleSelectionInFlatTree selection_in_flat_tree = CreateVisibleSelection(
SelectionInFlatTree::Builder()
- .Collapse(PositionInFlatTree::FirstPositionInNode(one))
+ .Collapse(PositionInFlatTree::FirstPositionInNode(*one))
.Extend(PositionInFlatTree::AfterNode(*eight))
.Build());
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisiblePosition.cpp ('k') | third_party/WebKit/Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698